-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bin ensure
should ensure versions match the target config file.
#205
Comments
seems like in order to implement something like this, we'd need some sort of bin.lock file which contains at least the path, md5 and version of the binary. Otherwise, there's no way for As a stopgap, I can implement this feature relying in the |
fixes #205 this is a breaking change because since everyone running `bin ensure` after this gets merged will result in all their binaries getting re-downloaded. This is good though since that will fix all the incorrect hashes that are wrong in the first place. I've decided not to add a flag to skip this check since checking hashes is the right thing to do in the first place. Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
@einarpersson this should have been addressed in the new release v0.18. LMK if that works for you. Keep in mind that running |
@marcosnils Looks good so far, I'll let you know otherwise! Great work! 👏 |
from @einarpersson:
Opening this issue as a follow-up of #204. As described in the title,
bin ensure
should also make all the binaries match the config file specsThe text was updated successfully, but these errors were encountered: