Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention stability of symbolizers #101

Closed
5 tasks done
yohanboniface opened this issue Jun 4, 2015 · 10 comments
Closed
5 tasks done

Mention stability of symbolizers #101

yohanboniface opened this issue Jun 4, 2015 · 10 comments

Comments

@yohanboniface
Copy link
Member

As discussed in #99, we'd like to be able to define the stability of each symbolizers.
Mainly because we want to push some unstable symbolizers to start having feedback from Mapnik community, and to declare some of them as deprecated when needed.

We need to push a 8.0.0 version for this.

Todo:

  • define which key to use; candidates at this time: stability, status
  • define expected values (and default one); candidates at this time: deprecated, experimental, unstable, stable
  • document it
  • apply status where needed in the reference
  • release

@springmeyer what else? Can you just give me some pointers about things to be done, I'll take care of them. :)

@yohanboniface yohanboniface changed the title Menstion stability of symbolizers Mention stability of symbolizers Jun 8, 2015
@yohanboniface
Copy link
Member Author

@springmeyer should I proceed on that? Anything more that need to be done? :)

@springmeyer
Copy link
Member

@yohanboniface - your todos look great. Thank you!

My preference would be status as key and deprecated, stable, unstable, and experimental as values.

proposed definitions:

  • stable: property is here to stay and its behavior is not anticipated to change
  • unstable: property is here to stay but its behavior/meaning of property may change (.e.g line-offset or text-dy as per Predictable offsetting on polygons mapnik#2851)
  • deprecated: property should not be used and will be removed in upcoming Major version of Mapnik (.e.g. marker-type which is replaced by file="shape://marker-name or text-min-distance which is replaced by text-repeat-distance and text-margin)
  • experimental: property should not be used and may dissapear, be re-named, or disappear at any time (text-largest-bbox-only as per add text-largest-bbox-only #99)

@yohanboniface
Copy link
Member Author

Thanks :)
Where do you suggest I put those definitions? In the README is fine?

@springmeyer
Copy link
Member

Yes, README is good.

yohanboniface added a commit that referenced this issue Jun 10, 2015
- completed CHANGELOG
- documented `status` key in README
- added `status` key where needed in 3.0.0/reference

cf #101
@yohanboniface
Copy link
Member Author

@springmeyer we should be ready for 8.0.0. release, unless you want to add more status keys in the reference.
Tell me if you want me to prepare anything more (git tag…) for releasing. :)

@springmeyer
Copy link
Member

@yohanboniface - just added you so you can npm publish npm owner add ybon.

Also added a contributing braindump in bc4dc6b.

Please go ahead and tag/publish if you'd like!

Followups needed on my end:

  • Ensure Carto does not get tripped up on the new properties
  • Ensure Mapbox studio/TileMill do not allow deprecated properties (for now).

@yohanboniface
Copy link
Member Author

Quick suggestion: we can automate the push to npm from Travis when pushing a new tag and tests passe: http://docs.travis-ci.com/user/deployment/npm/

@springmeyer
Copy link
Member

@yohanboniface Interesting, not seen that. I've never minded the manual npm publish myself, but I'm open if you think this would streamline things.

@yohanboniface
Copy link
Member Author

Is any action still needed here or can we close?

@springmeyer
Copy link
Member

springmeyer commented Sep 22, 2017

Let's close. Carto has been using this version of mapnik-reference for some time now without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants