-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add text-largest-bbox-only #99
Conversation
@springmeyer I see in the wiki that this option is sort of experimental (NOTE: this option may change or be renamed in the future), should we think about some |
Also the description of this option on the wiki is not very precise. One have to use this option for labeling multi geometries, not just polygons. |
Yes, I've hesitated to add this because I'd love to replace it mapnik/mapnik#1583. @talaj - what do you think: is the idea of being able to control labeling like that a good idea? If not then I should probably just stop hesitating and expose this option.
I think better to just make a call as per above. |
Seems to me that it's not the first case of feature that exists in Mapnik for a long but doesn't pop up on mapnik-reference because it's not considered stable enough. My opinion is that it would be much helpful for the community to add those features as soon as they exist, but with a key that define their stability status. |
Okay, thanks for pushing back: I'm in. We definitely need a way to tag things as deprecated. And so I like combining this into a single |
Excellent :) |
Well, it may require an upgrade of at least the minor tag, so we may target |
I think we should go to 8.0.0 because this will add to the reference scheme. It won't be breaking but will still be significant. |
@springmeyer I didn't notice mapnik/mapnik#1583 before. It's definitely good idea to use something like |
add text-largest-bbox-only
Adds missing property of text symbolizer.