Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore pull requests #117

Open
2 of 4 tasks
springmeyer opened this issue Mar 5, 2016 · 4 comments
Open
2 of 4 tasks

Restore pull requests #117

springmeyer opened this issue Mar 5, 2016 · 4 comments

Comments

@springmeyer
Copy link
Member

A few outstanding pull requests were automatically closed (and cannot be re-opened) now that I've deleted the master branch and we use gh-pages as default (#107 (comment)). This ticket is to track those pulls for revisiting when there is time:

@nebulon42
Copy link
Contributor

I plan to work on #61 and #62 again as time permits, because I think that they are important additions. However, accepting the changes into this repository would be a prerequisite for accepting them into carto.

@springmeyer
Copy link
Member Author

@nebulon42 - that is great you are interested in working on the group-symbolizer support. Also, with further thought I agree that it likely makes sense to land in mapnik-reference first. I'm open to this as long as we mark all the properties as experimental.

@talaj
Copy link
Member

talaj commented Nov 1, 2016

@springmeyer - given the fact that corresponding carto pull requests for #62 and #61 can never land and according to importance of mapnik-reference for non-carto users, what about to merge these pull requests with some "area of validity" introduced to exclude it from carto? Something similar to #101.

@springmeyer
Copy link
Member Author

👍 @talaj - Agree that anything in Mapnik should be visible in mapnik-reference irregardless of its binding in carto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@springmeyer @talaj @nebulon42 and others