fix: show window closing alert only when page is not saved #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriramveeraghanta
requested review from
Palanikannan1437 and
sriramveeraghanta
- Removed the `message` parameter, as it was not being used and not supported in modern browsers - Changed the `isActive` flag to a temporary flag and added a TODO comment to remove it later. - Implemented the `handleRouteChangeStart` function to handle route change events and prompt the user with a confirmation dialog before leaving the page. - Updated the dependencies of the `handleBeforeUnload` and `handleRouteChangeStart` callbacks. - Added event listeners for `beforeunload` and `routeChangeStart` events in the `useEffect` hook. - Cleaned up the event listeners in the cleanup function of the `useEffect` hook. fix: Fix reload confirmations in PageDetailsPage - Removed the TODO comment regarding fixing reload confirmations with MobX, as it has been resolved. - Passed the `pageStore?.isSubmitting === "submitting"` flag to the `useReloadConfirmations` hook instead of an undefined message. This commit refactors the `useReloadConfirmations` hook to improve its functionality and fixes the usage in the `PageDetailsPage` component.
Palanikannan1437
force-pushed
the
fix-page-confirm-close
branch
from
93e1259
to
555744e
Compare
|
Thanks so much @jlucaso1 for this PR, really appreciate it 🚀 I've pushed some changes along with your commit to remove the message parameter as modern browsers don't support it anyway and I've made some changes that now show an alert and prevents route changes too if the content is unsaved. DemoScreen.Recording.2024-02-07.at.4.30.25.PM.mov |
sriramveeraghanta
approved these changes
Feb 7, 2024
aaryan610
pushed a commit
that referenced
this pull request
Feb 8, 2024
* fix: show window closing alert only when page is not saved * chore: Refactor useReloadConfirmations hook - Removed the `message` parameter, as it was not being used and not supported in modern browsers - Changed the `isActive` flag to a temporary flag and added a TODO comment to remove it later. - Implemented the `handleRouteChangeStart` function to handle route change events and prompt the user with a confirmation dialog before leaving the page. - Updated the dependencies of the `handleBeforeUnload` and `handleRouteChangeStart` callbacks. - Added event listeners for `beforeunload` and `routeChangeStart` events in the `useEffect` hook. - Cleaned up the event listeners in the cleanup function of the `useEffect` hook. fix: Fix reload confirmations in PageDetailsPage - Removed the TODO comment regarding fixing reload confirmations with MobX, as it has been resolved. - Passed the `pageStore?.isSubmitting === "submitting"` flag to the `useReloadConfirmations` hook instead of an undefined message. This commit refactors the `useReloadConfirmations` hook to improve its functionality and fixes the usage in the `PageDetailsPage` component. --------- Co-authored-by: Palanikannan1437 <73993394+Palanikannan1437@users.noreply.github.com>
NarayanBavisetti
added a commit
that referenced
this pull request
May 8, 2024
* chore: breadcrumb component improvement (#3537) * chore: breadcrumb component improvement * chore: code refactor * fix: create issue modal project select (#3549) * chore: responsive and styling fixes (#3541) * fix: all issues spreadsheet sorting and kanban dnd for long lists (#3550) * fix all issues filter for spreadsheet view * fix kanban dnd with long lists * dev: validation for external id and external source (#3552) * dev: error response for duplicate items created through external apis * dev: return identifier and also add the validation for state * fix: validation for external id and external source * chore: cycle and module sidebar analytics improvement (#3559) * chore: cycle and module store update action updated * chore: cycle and module issue store actions updated * chore: cycle and module retrieve endpoints updated * fix: app sidebar z index and priority icon fix * chore: cycle and module sidebar and stats updated * chore: posthog events improved (#3554) * chore: events naming convention changed * chore: track element added for project related events * chore: track element added for cycle related events * chore: track element added for module related events * chore: issue related events updated * refactor: event tracker store * refactor: event-tracker store * fix: posthog changes --------- Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> * fix: build fixes * fix: sentry error fixes * chore: active cycle issue transfer validation (#3560) * fix: completed cycle list layout validation * fix: completed cycle kanban layout validation * fix: completed cycle spreadsheet layout validation * fix: date dropdown disabled fix * chore: quick action validation added for list, kanban and spreadsheet layout * fix: calendar layout validation added * fix: useberry script added * chore: added `None` filter option to the dashboard widgets (#3556) * chore: added tab change animation * chore: widgets filtering logic updated * refactor: issues list widget * fix: tab navigation transition * fix: extra top spacing on opening the peek overview * chore: removed email notification for new users (#3561) * chore: cycle and module sidebar improvement (#3562) * chore: module date validation (#3565) * app_release value handled (#3571) * chore: email trigger for new assignee (#3572) * dev: update the response for conflicting errors (#3568) * style: responsive breadcrumbs and headers for dashboard, projects, project issues, cycles, cycle issues, module issues (#3580) * fix: dashboard header z index and workspace active cycles fix (#3581) * fix: dashboard header z index fix * chore: workspace active cycles upgrade page improvement * fix: draft issue peek overview (#3582) * chore: project, view and shortcut modal alignment consistency * chore: issue highlight list layout improvement * fix: draft issue peek overview fix * fix: draft issue layout inline editing * chore: module issue count (#3566) * chore: mention notification and webhook faliure (#3573) * fix: mention rstrip error * chore: webhook deactivation email * chore: changed template * chore: current site for external api's * chore: mention in template displayed * chore: mention tag fix * chore: comment user name displayed * dev: create fake data for issues (#104) * dev: create fake data for issues * dev: remove endpoint * dev: update faker script * chore: workspace dashboard refactor (#3584) * fix: faker import (#111) * fix: show window closing alert only when page is not saved (#3577) * fix: show window closing alert only when page is not saved * chore: Refactor useReloadConfirmations hook - Removed the `message` parameter, as it was not being used and not supported in modern browsers - Changed the `isActive` flag to a temporary flag and added a TODO comment to remove it later. - Implemented the `handleRouteChangeStart` function to handle route change events and prompt the user with a confirmation dialog before leaving the page. - Updated the dependencies of the `handleBeforeUnload` and `handleRouteChangeStart` callbacks. - Added event listeners for `beforeunload` and `routeChangeStart` events in the `useEffect` hook. - Cleaned up the event listeners in the cleanup function of the `useEffect` hook. fix: Fix reload confirmations in PageDetailsPage - Removed the TODO comment regarding fixing reload confirmations with MobX, as it has been resolved. - Passed the `pageStore?.isSubmitting === "submitting"` flag to the `useReloadConfirmations` hook instead of an undefined message. This commit refactors the `useReloadConfirmations` hook to improve its functionality and fixes the usage in the `PageDetailsPage` component. --------- Co-authored-by: Palanikannan1437 <73993394+Palanikannan1437@users.noreply.github.com> * chore: posthog code refactor (#3586) * dev: update faker script to take inputs (#112) * dev: update faker script to take inputs * dev: update while check --------- Co-authored-by: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com> Co-authored-by: Ramesh Kumar Chandra <31303617+rameshkumarchandra@users.noreply.github.com> Co-authored-by: rahulramesha <71900764+rahulramesha@users.noreply.github.com> Co-authored-by: Nikhil <118773738+pablohashescobar@users.noreply.github.com> Co-authored-by: Lakhan Baheti <94619783+1akhanBaheti@users.noreply.github.com> Co-authored-by: Aaryan Khandelwal <65252264+aaryan610@users.noreply.github.com> Co-authored-by: Bavisetti Narayan <72156168+NarayanBavisetti@users.noreply.github.com> Co-authored-by: Manish Gupta <59428681+mguptahub@users.noreply.github.com> Co-authored-by: João Lucas de Oliveira Lopes <55464917+jlucaso1@users.noreply.github.com> Co-authored-by: Palanikannan1437 <73993394+Palanikannan1437@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.