Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA-3117::[PWA] display number of items in cart instead of quantities… #4149

Merged
merged 8 commits into from
Sep 27, 2023
Merged

PWA-3117::[PWA] display number of items in cart instead of quantities… #4149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
07cbfbc
PWA-3117::[PWA] display number of items in cart instead of quantities…
glo82145 Jul 27, 2023
15c58ed
Merge branch 'develop' into PWA-3117
glo82145 Jul 27, 2023
3028f27
Merge branch 'develop' into PWA-3117
glo82145 Jul 31, 2023
53a6a1f
Merge branch 'develop' into PWA-3117
glo82145 Sep 5, 2023
fb51b2c
Update useCartTrigger.js
glo82145 Sep 13, 2023
f842de8
Update useCartTrigger.js
glo82145 Sep 13, 2023
664b1ed
PWA-3117:: display number of items in cart instead of quantities not …
glo82145 Sep 13, 2023
f6182cc
Merge branch 'develop' into PWA-3117
glo82145 Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/peregrine/lib/talons/Header/cartTriggerFragments.gql.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@ export const CartTriggerFragment = gql`
fragment CartTriggerFragment on Cart {
id
total_quantity
total_summary_quantity_including_config
}
`;
2 changes: 1 addition & 1 deletion packages/peregrine/lib/talons/Header/useCartTrigger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const useCartTrigger = props => {
errorPolicy: 'all'
});

const itemCount = data?.cart?.total_quantity || 0;
const itemCount = data?.cart?.total_summary_quantity_including_config || 0;

const handleTriggerClick = useCallback(() => {
// Open the mini cart.
Expand Down
20 changes: 4 additions & 16 deletions packages/venia-ui/lib/components/Header/__tests__/__snapshots__/cartTrigger.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Array [
<div>
<button
aria-expanded={false}
aria-label="Toggle mini cart. You have 100 items in your cart."
aria-label="Toggle mini cart. You have 0 items in your cart."
onClick={[Function]}
>
<span>
Expand Down Expand Up @@ -34,14 +34,11 @@ Array [
/>
</svg>
</span>
<span>
99+
</span>
</button>
</div>,
<button
aria-expanded={false}
aria-label="Toggle mini cart. You have 100 items in your cart."
aria-label="Toggle mini cart. You have 0 items in your cart."
onClick={[Function]}
>
<span>
Expand Down Expand Up @@ -70,9 +67,6 @@ Array [
/>
</svg>
</span>
<span>
99+
</span>
</button>,
<require('../MiniCart')
isOpen={false}
Expand All @@ -86,7 +80,7 @@ Array [
<div>
<button
aria-expanded={false}
aria-label="Toggle mini cart. You have 10 items in your cart."
aria-label="Toggle mini cart. You have 0 items in your cart."
onClick={[Function]}
>
<span>
Expand Down Expand Up @@ -115,14 +109,11 @@ Array [
/>
</svg>
</span>
<span>
10
</span>
</button>
</div>,
<button
aria-expanded={false}
aria-label="Toggle mini cart. You have 10 items in your cart."
aria-label="Toggle mini cart. You have 0 items in your cart."
onClick={[Function]}
>
<span>
Expand Down Expand Up @@ -151,9 +142,6 @@ Array [
/>
</svg>
</span>
<span>
10
</span>
</button>,
<require('../MiniCart')
isOpen={false}
Expand Down