PWA-3117::[PWA] display number of items in cart instead of quantities… #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section. |
glo82145
added
the
version: Minor
|
run lighthouse-desktop |
|
Successfully started codebuild job for |
|
run lighthouse-mobile |
|
Successfully started codebuild job for |
RaghavendraTirumalasetti
approved these changes
Sep 27, 2023
m2-community-project
bot
moved this from Ready for Review
to Reviewer Approved
in Pull Request Progress
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
m2-community-project
bot
moved this from Reviewer Approved
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preconditions
Leave only Yes or No as the answer
Issue is reproducible on the latest mainline, without Sample Data: Yes
JIRA was checked for similar/duplicated issues: Yes
GitHub project was checked: Yes
Merchdocs and Devdocs were checked: Yes
Double Check List L3 was checked: Yes
Steps to reproduce
Install PWA studio with [ 2.4-develop ]
Check the [ Display Cart Summary ] configuration from [ Store > Configuration > Sales > Checkout > My Cart Link > Display Cart Summary ]. The default value should available as [ Display item quantities ]
Create a simple product from the backend
Add 5 quantities to cart from the above product. The minicart will display like below. Which is correct with the default [ Display Cart Summary ] configuration.
Change the [ Display Cart Summary ] configuration to [ Display number of items in cart ]
Remove items from the shopping cart and again add 5 quantities from the same product
Check the mini-cart product count
Actual results
Minicart still displays [ 5 ].
Expected results
When we set [ Display Cart Summary ] configuration to [ Display number of items in cart ], it should not display the item quantity. The value it should display is [ 1 ], which is the number of unique items in the cart.
Closes #PWA-3117
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist