Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rearview does not allow selecting multiple series with {...} #42

Closed
shawnjgoff opened this issue May 15, 2014 · 5 comments · Fixed by livingsocial/rearview-engine#4
Closed

Rearview does not allow selecting multiple series with {...} #42

shawnjgoff opened this issue May 15, 2014 · 5 comments · Fixed by livingsocial/rearview-engine#4
Assignees
@talbright
Labels
bug

Comments

@shawnjgoff
Copy link

Graphite allows selecting multiple series using {...}. A useful example of this syntax is given in the documentation for the averageSeriesWithWildcards function

When trying to use this syntax in Rearview, it shows a flash that says "Metrics contains an invalid metric".
@shawnjgoff
Copy link
Author

The group function can be used as a workaround.

@talbright
Copy link
Contributor

I'm pretty sure I know the issue, sounds like a bug in the parser I wrote. Would you mind cutting and pasting the complete syntax you used?

@talbright talbright added the bug label Jun 4, 2014
@shawnjgoff
Copy link
Author

sumSeries(server.app1.memory.memory.{buffered,cached,free})

@talbright
Copy link
Contributor

Thought so, I know the problem. I'll work with @steveakers to get a fix in for this.

@talbright talbright self-assigned this Jun 6, 2014
talbright pushed a commit to talbright/rearview-engine that referenced this issue Jun 6, 2014
Add to list of valid chars in path_segment
dc61680 
Allow path segments like:

host.cpu-[0-7].cpu-{user,system}.value

Please note that the parser is not strict. For example it would allow:

host.cpu-][.cpu-}{.value

Fixes livingsocial/rearview#42

See:
http://graphite.readthedocs.org/en/0.9.10/functions.html#graphite.render.functions.averageSeriesWithWildcards
@talbright talbright mentioned this issue Jun 6, 2014
Merged
@talbright
Copy link
Contributor

@shawnjgoff you can update your gemfile to get the update:

 gem 'rearview', '1.2.2.rc.1'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talbright talbright

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add to list of valid chars in path_segment talbright/rearview-engine
2 participants
@talbright @shawnjgoff