Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to list of valid chars in path_segment #4

Merged
merged 1 commit into from
Jun 6, 2014

Conversation

talbright
Copy link
Contributor

Allow path segments like:

host.cpu-[0-7].cpu-{user,system}.value

Please note that the parser is not strict. For example it would allow:

host.cpu-][.cpu-}{.value

Fixes livingsocial/rearview#42

See:
http://graphite.readthedocs.org/en/0.9.10/functions.html#graphite.render.functions.averageSeriesWithWildcards

Allow path segments like:

host.cpu-[0-7].cpu-{user,system}.value

Please note that the parser is not strict. For example it would allow:

host.cpu-][.cpu-}{.value

Fixes livingsocial/rearview#42

See:
http://graphite.readthedocs.org/en/0.9.10/functions.html#graphite.render.functions.averageSeriesWithWildcards
@talbright
Copy link
Contributor Author

@steveakers I'm going to create PR's from now on instead of merging directly into master. This allows Travis to run on the PR, provides more visibility and tracking, and gives us a chance to discuss the PR before merging if necessary.

Once the build passes I'll handle the merging myself, so you don't need to do anything.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling dc61680 on talbright:fix-parser-wilcards into 176cbcd on livingsocial:master.

talbright added a commit that referenced this pull request Jun 6, 2014
Add to list of valid chars in path_segment
@talbright talbright merged commit 589ed95 into livingsocial:master Jun 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rearview does not allow selecting multiple series with {...}
2 participants