Refactor route table ID parsing #566
Conversation
tyll
force-pushed
the
tabelid
branch
2 times, most recently
from
0ee4eeb
to
fb1ea1f
Compare
Codecov ReportBase: 42.95% // Head: 19.87% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
===========================================
- Coverage 42.95% 19.87% -23.09%
===========================================
Files 13 5 -8
Lines 3043 1238 -1805
Branches 354 353 -1
===========================================
- Hits 1307 246 -1061
+ Misses 1736 992 -744
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Proper code coverage requires linux-system-roles/.github#11 and linux-system-roles/tox-lsr#109 to be merged and this repo be updated with the changes. |
tyll
force-pushed
the
tabelid
branch
2 times, most recently
from
3e9d8b9
to
dc53cd9
Compare
merged - also submitted #569 for the network role
merged - released tox-lsr 2.13.2 - submitted #570 I suggest merging #570 first, then I will rebase #569, then once that is merged, you can rebase this PR |
|
Thanks, I merged your PRs and rebased this one. |
tyll
force-pushed
the
tabelid
branch
2 times, most recently
from
43912f4
to
038fb77
Compare
|
Markdownlint is broken: actionshub/markdownlint#35 |
Simplify the parsing of route table IDs to avoid unnecessary exception handling that makes the code harder to understand and triggers CodeQL warnings. Also re-organize the unit tests and add a missing test for table IDs higher than 0xFFFF_FFFF to achieve full test coverage. Signed-off-by: Till Maas <opensource@till.name>
The route tables names are called names, also use "name" in the regex constant instead of "alias". Signed-off-by: Till Maas <opensource@till.name>
Signed-off-by: Till Maas <opensource@till.name>
Simplify the parsing of route table IDs to avoid unnecessary exception handling that makes the code harder to understand and triggers CodeQL warnings.
Related to #565