Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address CodeQL warnings #565

Open
nhosoi opened this issue Feb 10, 2023 · 4 comments
Open

Address CodeQL warnings #565

nhosoi opened this issue Feb 10, 2023 · 4 comments

Comments

@nhosoi
Copy link
Contributor

nhosoi commented Feb 10, 2023

CodeQL reports following warnings. It'd be preferable to clean them up.
codeql.network.txt

This is an incomplete pull request containing useful discussions.
#558

@tyll
Copy link
Member

tyll commented Feb 10, 2023

Thanks, how is the CodeQL report generated? Since CodeQL is enabled, I was expecting the results to be part of the current checks but, for example at: https://github.com/linux-system-roles/network/actions/runs/4138105148

@nhosoi
Copy link
Contributor Author

nhosoi commented Feb 10, 2023

Thanks, how is the CodeQL report generated?

We ported the command lines that appeared in the codeql action to https://github.com/linux-system-roles/tox-lsr/blob/main/src/tox_lsr/test_scripts/runcodeql.sh. Actually, the result contains warnings in addition to the failures. And the network role is free from "failures".

@tyll
Copy link
Member

tyll commented Feb 10, 2023

Ah, thanks for the clarification. Now I found the warnings at https://github.com/linux-system-roles/network/security/code-scanning

@nhosoi
Copy link
Contributor Author

nhosoi commented Feb 10, 2023

@tyll, I've opened a pr for the tox command tox -e codeql.
linux-system-roles/tox-lsr#107

It clearly states as follows.

CodeQL result file on network:
 - failed: /path/to/network/.tox/codeql/results/codeql-failed-run.sarif
 - all: /path/to/network/.tox/codeql/results/python.sarif
CODEQL RESULT
[
  {
    "ruleId": "py/empty-except",
    <<snip>>
    "partialFingerprints": {
      "primaryLocationLineHash": "dd9fcbb08231241c:1",
      "primaryLocationStartColumnFingerprint": "37"
    }
  }
]
PASS: Found 29 items; none of them are failures.
___________________________________ summary ____________________________________
  codeql: commands succeeded
  congratulations :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants