Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed: [M3-7554, M3-7559] - Post Release Cleanup Parent/Child Feature Flags #10497

Merged
merged 6 commits into from
May 21, 2024

Conversation

jaalah-akamai
Copy link
Contributor

@jaalah-akamai jaalah-akamai commented May 21, 2024

Description 📝

Remove the parentChildAccountAccess feature flag logic now that the feature has been in production for some time.

Changes 🔄

  • Removed feature flags from code, unit tests, and cypress e2e tests

Target release date 🗓️

Next release: 5/28

How to test 🧪

Prerequisites

Verification steps

  • Run unit tests: yarn test
  • Run E2E tests:
yarn cy:run -s "cypress/e2e/core/account/account-cancellation.spec.ts,cypress/e2e/core/account/account-login-history.spec.ts,cypress/e2e/core/account/display-settings.spec.ts,cypress/e2e/core/account/personal-access-tokens.spec.ts,cypress/e2e/core/account/user-permissions.spec.ts,cypress/e2e/core/account/user-verification-banner.spec.ts,cypress/e2e/core/account/users-landing-page.spec.ts,cypress/e2e/core/billing/billing-contact.spec.ts,cypress/e2e/core/billing/restricted-user-billing.spec.ts,cypress/e2e/core/parentChild/account-switching.spec.ts,cypress/e2e/core/parentChild/token-expiration.spec.ts"
  • Ensure that parent child features are not displayed for default accounts.
  • Ensure that the features are enabled for parent/child accounts.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jaalah-akamai
Copy link
Contributor Author

Re-opened under my fork 🍴

Copy link

github-actions bot commented May 21, 2024

Coverage Report:
Base Coverage: 81.62%
Current Coverage: 81.62%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the 🍴 is correct now.

Pushed a quick change to the changeset suggested on the original PR and merged in develop because this branch was based off of old changes and CI was going to fail + was holding things up.

Should be good once the tests pass.

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels May 21, 2024
@jaalah-akamai jaalah-akamai merged commit 82dc241 into linode:develop May 21, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Parent / Child Account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants