removed: [M3-7554, M3-7559] - Post Release Cleanup Parent/Child Featu…

…re Flags (#10497) Co-authored-by: Joe D'Amore <jdamore@linode.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> Co-authored-by: mjac0bs <mjacobs@akamai.com>
linode · May 21, 2024 · 82dc241 · 82dc241
1 parent bb6c22c
commit 82dc241
Show file tree

Hide file tree

Showing 33 changed files with 166 additions and 558 deletions.
diff --git a/packages/manager/.changeset/pr-10489-removed-1716225501082.md b/packages/manager/.changeset/pr-10489-removed-1716225501082.md
@@ -0,0 +1,5 @@
+---
+"@linode/manager": Removed
+---
+
+`parentChildAccountAccess` feature flag ([#10489](https://github.com/linode/manager/pull/10489))
diff --git a/packages/manager/cypress/e2e/core/account/account-cancellation.spec.ts b/packages/manager/cypress/e2e/core/account/account-cancellation.spec.ts
@@ -27,11 +27,6 @@ import {
 } from 'support/util/random';
 import type { CancelAccount } from '@linode/api-v4';
 import { mockWebpageUrl } from 'support/intercepts/general';
-import {
-  mockAppendFeatureFlags,
-  mockGetFeatureFlagClientstream,
-} from 'support/intercepts/feature-flags';
-import { makeFeatureFlagData } from 'support/util/feature-flags';
 
 describe('Account cancellation', () => {
   /*
@@ -325,12 +320,6 @@ describe('Parent/Child account cancellation', () => {
 
     const cancellationComments = randomPhrase();
 
-    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-    mockAppendFeatureFlags({
-      parentChildAccountAccess: makeFeatureFlagData(true),
-    }).as('getFeatureFlags');
-    mockGetFeatureFlagClientstream().as('getClientStream');
-
     mockGetAccount(mockAccount).as('getAccount');
     mockGetProfile(mockProfile).as('getProfile');
     mockCancelAccountError(cancellationPaymentErrorMessage, 409).as(

diff --git a/packages/manager/cypress/e2e/core/account/account-login-history.spec.ts b/packages/manager/cypress/e2e/core/account/account-login-history.spec.ts
@@ -6,12 +6,7 @@ import { profileFactory } from 'src/factories';
 import { accountLoginFactory } from 'src/factories/accountLogin';
 import { formatDate } from 'src/utilities/formatDate';
 import { mockGetAccountLogins } from 'support/intercepts/account';
-import {
-  mockAppendFeatureFlags,
-  mockGetFeatureFlagClientstream,
-} from 'support/intercepts/feature-flags';
 import { mockGetProfile } from 'support/intercepts/profile';
-import { makeFeatureFlagData } from 'support/util/feature-flags';
 import { PARENT_USER } from 'src/features/Account/constants';
 
 describe('Account login history', () => {
@@ -42,15 +37,9 @@ describe('Account login history', () => {
       'getAccountLogins'
     );
 
-    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-    mockAppendFeatureFlags({
-      parentChildAccountAccess: makeFeatureFlagData(false),
-    }).as('getFeatureFlags');
-    mockGetFeatureFlagClientstream().as('getClientStream');
-
     // Navigate to Account Login History page.
     cy.visitWithLogin('/account/login-history');
-    cy.wait(['@getClientStream', '@getFeatureFlags', '@getProfile']);
+    cy.wait(['@getProfile']);
 
     // Confirm helper text above table is visible.
     cy.findByText(
@@ -114,15 +103,9 @@ describe('Account login history', () => {
 
     mockGetProfile(mockProfile).as('getProfile');
 
-    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-    mockAppendFeatureFlags({
-      parentChildAccountAccess: makeFeatureFlagData(true),
-    }).as('getFeatureFlags');
-    mockGetFeatureFlagClientstream().as('getClientStream');
-
     // Navigate to Account Login History page.
     cy.visitWithLogin('/account/login-history');
-    cy.wait(['@getClientStream', '@getFeatureFlags', '@getProfile']);
+    cy.wait(['@getProfile']);
 
     // Confirm helper text above table and table are not visible.
     cy.findByText(
@@ -149,15 +132,9 @@ describe('Account login history', () => {
 
     mockGetProfile(mockProfile).as('getProfile');
 
-    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-    mockAppendFeatureFlags({
-      parentChildAccountAccess: makeFeatureFlagData(true),
-    }).as('getFeatureFlags');
-    mockGetFeatureFlagClientstream().as('getClientStream');
-
     // Navigate to Account Login History page.
     cy.visitWithLogin('/account/login-history');
-    cy.wait(['@getClientStream', '@getFeatureFlags', '@getProfile']);
+    cy.wait(['@getProfile']);
 
     // Confirm helper text above table and table are not visible.
     cy.findByText(

diff --git a/packages/manager/cypress/e2e/core/account/display-settings.spec.ts b/packages/manager/cypress/e2e/core/account/display-settings.spec.ts
@@ -1,10 +1,5 @@
 import { Profile } from '@linode/api-v4';
 import { profileFactory } from '@src/factories';
-import {
-  mockAppendFeatureFlags,
-  mockGetFeatureFlagClientstream,
-} from 'support/intercepts/feature-flags';
-import { makeFeatureFlagData } from 'support/util/feature-flags';
 import { mockGetProfile } from 'support/intercepts/profile';
 import { getProfile } from 'support/api/account';
 import { interceptGetProfile } from 'support/intercepts/profile';
@@ -18,12 +13,6 @@ const verifyUsernameAndEmail = (
   tooltip: string,
   checkEmail: boolean
 ) => {
-  // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-  mockAppendFeatureFlags({
-    parentChildAccountAccess: makeFeatureFlagData(true),
-  }).as('getFeatureFlags');
-  mockGetFeatureFlagClientstream().as('getClientStream');
-
   mockGetProfile(mockRestrictedProxyProfile);
 
   // Navigate to User Profile page

diff --git a/packages/manager/cypress/e2e/core/account/personal-access-tokens.spec.ts b/packages/manager/cypress/e2e/core/account/personal-access-tokens.spec.ts
@@ -15,11 +15,6 @@ import {
 } from 'support/intercepts/profile';
 import { randomLabel, randomString } from 'support/util/random';
 import { ui } from 'support/ui';
-import {
-  mockAppendFeatureFlags,
-  mockGetFeatureFlagClientstream,
-} from 'support/intercepts/feature-flags';
-import { makeFeatureFlagData } from 'support/util/feature-flags';
 import { PROXY_USER_RESTRICTED_TOOLTIP_TEXT } from 'src/features/Account/constants';
 
 describe('Personal access tokens', () => {
@@ -278,24 +273,13 @@ describe('Personal access tokens', () => {
     });
     const proxyUserProfile = profileFactory.build({ user_type: 'proxy' });
 
-    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-    mockAppendFeatureFlags({
-      parentChildAccountAccess: makeFeatureFlagData(true),
-    }).as('getFeatureFlags');
-    mockGetFeatureFlagClientstream().as('getClientStream');
-
     mockGetProfile(proxyUserProfile);
     mockGetPersonalAccessTokens([proxyToken]).as('getTokens');
     mockGetAppTokens([]).as('getAppTokens');
     mockRevokePersonalAccessToken(proxyToken.id).as('revokeToken');
 
     cy.visitWithLogin('/profile/tokens');
-    cy.wait([
-      '@getClientStream',
-      '@getFeatureFlags',
-      '@getTokens',
-      '@getAppTokens',
-    ]);
+    cy.wait(['@getTokens', '@getAppTokens']);
 
     // Find token in list, confirm "Rename" is disabled and tooltip displays.
     cy.findByText(proxyToken.label)

diff --git a/packages/manager/cypress/e2e/core/account/user-permissions.spec.ts b/packages/manager/cypress/e2e/core/account/user-permissions.spec.ts
@@ -11,14 +11,9 @@ import {
   mockUpdateUser,
   mockUpdateUserGrants,
 } from 'support/intercepts/account';
-import {
-  mockAppendFeatureFlags,
-  mockGetFeatureFlagClientstream,
-} from 'support/intercepts/feature-flags';
 import { mockGetProfile } from 'support/intercepts/profile';
 import { ui } from 'support/ui';
 import { shuffleArray } from 'support/util/arrays';
-import { makeFeatureFlagData } from 'support/util/feature-flags';
 import { randomLabel } from 'support/util/random';
 
 // Message shown when user has unrestricted account access.
@@ -504,12 +499,6 @@ describe('User permission management', () => {
       global: { account_access: 'read_write' },
     });
 
-    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-    mockAppendFeatureFlags({
-      parentChildAccountAccess: makeFeatureFlagData(true),
-    }).as('getFeatureFlags');
-    mockGetFeatureFlagClientstream().as('getClientStream');
-
     mockGetUsers([mockActiveUser, mockRestrictedUser]).as('getUsers');
     mockGetUser(mockActiveUser);
     mockGetUserGrants(mockActiveUser.username, mockUserGrants);
@@ -520,7 +509,6 @@ describe('User permission management', () => {
     );
     mockGetUser(mockRestrictedUser);
     mockGetUserGrants(mockRestrictedUser.username, mockUserGrants);
-    cy.wait(['@getClientStream', '@getFeatureFlags']);
 
     cy.get('[data-qa-global-section]')
       .should('be.visible')
@@ -573,12 +561,6 @@ describe('User permission management', () => {
       global: { account_access: 'read_write' },
     });
 
-    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-    mockAppendFeatureFlags({
-      parentChildAccountAccess: makeFeatureFlagData(true),
-    }).as('getFeatureFlags');
-    mockGetFeatureFlagClientstream().as('getClientStream');
-
     mockGetUsers([mockRestrictedProxyUser]).as('getUsers');
     mockGetUser(mockChildUser);
     mockGetUserGrants(mockChildUser.username, mockUserGrants);
@@ -590,8 +572,6 @@ describe('User permission management', () => {
       `/account/users/${mockRestrictedProxyUser.username}/permissions`
     );
 
-    cy.wait(['@getClientStream', '@getFeatureFlags']);
-
     cy.findByText('Parent User Permissions', { exact: false }).should(
       'be.visible'
     );

diff --git a/packages/manager/cypress/e2e/core/account/user-verification-banner.spec.ts b/packages/manager/cypress/e2e/core/account/user-verification-banner.spec.ts
@@ -7,13 +7,8 @@ import {
   mockGetUsers,
 } from 'support/intercepts/account';
 import { mockGetSecurityQuestions } from 'support/intercepts/profile';
-import {
-  mockAppendFeatureFlags,
-  mockGetFeatureFlagClientstream,
-} from 'support/intercepts/feature-flags';
 import { ui } from 'support/ui';
 import { mockGetProfile } from 'support/intercepts/profile';
-import { makeFeatureFlagData } from 'support/util/feature-flags';
 import { verificationBannerNotice } from 'support/constants/user';
 
 describe('User verification banner', () => {
@@ -46,12 +41,6 @@ describe('User verification banner', () => {
       global: { account_access: 'read_write' },
     });
 
-    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-    mockAppendFeatureFlags({
-      parentChildAccountAccess: makeFeatureFlagData(true),
-    }).as('getFeatureFlags');
-    mockGetFeatureFlagClientstream();
-
     mockGetUsers([mockRestrictedProxyUser]);
     mockGetUser(mockChildUser);
     mockGetUserGrants(mockChildUser.username, mockUserGrants);
@@ -128,12 +117,6 @@ describe('User verification banner', () => {
     mockSecurityQuestions.security_questions[2].response =
       mockSecurityQuestionAnswers[2];
 
-    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-    mockAppendFeatureFlags({
-      parentChildAccountAccess: makeFeatureFlagData(true),
-    }).as('getFeatureFlags');
-    mockGetFeatureFlagClientstream().as('getClientStream');
-
     mockGetUsers([mockRestrictedProxyUser]).as('getUsers');
     mockGetUser(mockChildUser);
     mockGetUserGrants(mockChildUser.username, mockUserGrants);
@@ -211,12 +194,6 @@ describe('User verification banner', () => {
     mockSecurityQuestions.security_questions[2].response =
       mockSecurityQuestionAnswers[2];
 
-    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-    mockAppendFeatureFlags({
-      parentChildAccountAccess: makeFeatureFlagData(true),
-    }).as('getFeatureFlags');
-    mockGetFeatureFlagClientstream().as('getClientStream');
-
     mockGetUsers([mockRestrictedProxyUser]).as('getUsers');
     mockGetUser(mockChildUser);
     mockGetUserGrants(mockChildUser.username, mockUserGrants);

diff --git a/packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts b/packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
@@ -10,16 +10,11 @@ import {
   mockGetUsers,
   mockDeleteUser,
 } from 'support/intercepts/account';
-import {
-  mockAppendFeatureFlags,
-  mockGetFeatureFlagClientstream,
-} from 'support/intercepts/feature-flags';
 import {
   mockGetProfile,
   mockGetProfileGrants,
 } from 'support/intercepts/profile';
 import { ui } from 'support/ui';
-import { makeFeatureFlagData } from 'support/util/feature-flags';
 import { randomLabel } from 'support/util/random';
 import { PARENT_USER } from 'src/features/Account/constants';
 
@@ -65,12 +60,6 @@ const initTestUsers = (profile: Profile, enableChildAccountAccess: boolean) => {
     global: { child_account_access: enableChildAccountAccess },
   });
 
-  // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-  mockAppendFeatureFlags({
-    parentChildAccountAccess: makeFeatureFlagData(true),
-  }).as('getFeatureFlags');
-  mockGetFeatureFlagClientstream().as('getClientStream');
-
   // Initially mock user with unrestricted account access.
   mockGetUsers(mockUsers).as('getUsers');
   mockGetUser(mockRestrictedParentWithoutChildAccountAccess);
@@ -228,12 +217,6 @@ describe('Users landing page', () => {
       restricted: false,
     });
 
-    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-    mockAppendFeatureFlags({
-      parentChildAccountAccess: makeFeatureFlagData(true),
-    }).as('getFeatureFlags');
-    mockGetFeatureFlagClientstream().as('getClientStream');
-
     // Initially mock user with unrestricted account access.
     mockGetUsers([mockUser]).as('getUsers');
     mockGetUser(mockUser);
@@ -276,12 +259,6 @@ describe('Users landing page', () => {
       global: { account_access: 'read_write' },
     });
 
-    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-    mockAppendFeatureFlags({
-      parentChildAccountAccess: makeFeatureFlagData(true),
-    }).as('getFeatureFlags');
-    mockGetFeatureFlagClientstream().as('getClientStream');
-
     mockGetUsers([mockRestrictedProxyUser]).as('getUsers');
     mockGetUser(mockChildUser);
     mockGetUserGrants(mockChildUser.username, mockUserGrants);
@@ -466,12 +443,6 @@ describe('Users landing page', () => {
       restricted: true,
     });
 
-    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-    mockAppendFeatureFlags({
-      parentChildAccountAccess: makeFeatureFlagData(false),
-    }).as('getFeatureFlags');
-    mockGetFeatureFlagClientstream().as('getClientStream');
-
     mockGetUsers([mockUser]).as('getUsers');
     mockGetUser(mockUser);
     mockGetUserGrantsUnrestrictedAccess(mockUser.username);
@@ -565,7 +536,6 @@ describe('Users landing page', () => {
       expect(intercept.request.body['restricted']).to.equal(newUser.restricted);
     });
     cy.wait('@getUsers');
-    cy.wait(['@getClientStream', '@getFeatureFlags']);
 
     // the new user is displayed in the user list
     cy.findByText(newUser.username).should('be.visible');
@@ -587,12 +557,6 @@ describe('Users landing page', () => {
       restricted: false,
     });
 
-    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
-    mockAppendFeatureFlags({
-      parentChildAccountAccess: makeFeatureFlagData(false),
-    }).as('getFeatureFlags');
-    mockGetFeatureFlagClientstream().as('getClientStream');
-
     mockGetUsers([mockUser, additionalUser]).as('getUsers');
     mockGetUser(mockUser);
     mockGetUserGrantsUnrestrictedAccess(mockUser.username);