Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipped confirmCommit defaulting to false => reverting commit to normal commit #143

Open
kjvelarde opened this issue Nov 4, 2020 · 2 comments

Comments

@kjvelarde
Copy link

version: latest

Config:
skipQuestions: ['breaking', 'footer', 'confirmCommit']

When you skip confirm commit it doesn't apply the commit from zen and commits successfully with the normal commit(not zen)

Step:
git commit -m test
--- interactive zen
git log -1
--- "test"

should be the type(scope):subject

@kjvelarde
Copy link
Author

Also with hook via husky: (standalone/ not standalone)

exec < /dev/tty && git cz --hook

When prompt to confirm and answered no
still commits with the normal commit

this might not be the adapter's issue but what do you think?

kjvelarde added a commit to kjvelarde/cz-customizable that referenced this issue Nov 4, 2020
@cedricdelpoux
Copy link

@kjvelarde Did you make a PR with your changes? I still have #142 issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants