Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Throw exception when minProcesses is set to zero #988

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

themsaid
Copy link
Member

No description provided.

@taylorotwell taylorotwell merged commit 0153a31 into laravel:5.x Mar 15, 2021
@dillingham
Copy link

dillingham commented Mar 16, 2021

@themsaid thanks for adding this. Just a thought.. what if this and others described in your book were part of a horizon:validate command so they could be discovered sooner? Might also be a nice reference of all the ways we can misconfigure things and added to CI pipelines before deploying

@ThaDaVos
Copy link

Out of curiosity - why was this changed? I've had no issues having it set to 0 - keeps the CPU nice and quiet for me - especially when running locally during development

@driesvints
Copy link
Member

There always needs to be at least one process. Otherwise it doesn't work.

@ThaDaVos
Copy link

I've got a whole project setup with multiple queues (it's lumen, so probably used Horizon 3 or 4 I guess) - but all queues are set to minProcesses 0 - it may take a second, but they still do pickup their jobs and process them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants