Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php artisan horizon:validate #1000

Closed
dillingham opened this issue Apr 1, 2021 · 4 comments
Closed

php artisan horizon:validate #1000

dillingham opened this issue Apr 1, 2021 · 4 comments

Comments

@dillingham
Copy link

There have been tips on how to not misconfigure horizon in themsaid's book and a few times on twitter.

I think it would be pretty awesome if there was a command that reads the config and outputs warnings.

Example tip: https://twitter.com/themsaid/status/1371474388718063616

Could be awesome if the exit code stopped CI / deployments

@driesvints
Copy link
Member

We've actually begon to implement exception throwing when misconfiguration happened which is a more explicit way of informing devs that something is misconfigured. It's probably best that we continue doing that if anything else pops up.

We've implemented the following PR for the tweet you mention: #988

@driesvints
Copy link
Member

Just saw you commented on that. We're not pursuing a validate command at this moment, sorry.

@dillingham
Copy link
Author

@driesvints thank you for the details. I think those exceptions are great
I just wanted to put it on your radar cause I think its kind of a cool idea.

@driesvints
Copy link
Member

@dillingham if you find any more use cases for misconfiguration definitely let us know or send in a PR to handle those. That way we can prevent people from misconfiguring their Horizon setups.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants