Remove job ID from title #768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like laravel/framework which suggests predis (and people can choose to use phpredis instead), Horizon should suggest it so people using phpredis do not needlessly install a dependency. Horizon relies on the redis config in config/database.php anyway, and trusts that the user correctly fills in that information. Requiring the user to install phpredis or predis herself is no different from what other parts of Laravel using Redis already do.
- Added predis to the dev dependencies so the build works - Also suggest ext-redis so people can choose
Co-Authored-By: ThomHurks <thomhurks@gmail.com>
[4.0] Suggest predis instead of requiring it
[4.0] Changed default Redis prefix
# Conflicts: # CHANGELOG.md
Better format, the default app_name already set in the app config.
[4.0] Change format
Revert "[4.0] Change format"
# Conflicts: # CHANGELOG.md
# Conflicts: # .travis.yml # composer.json
[4.x] Rename asset command
# Conflicts: # CHANGELOG.md
Added "Reserved" icon to indicate which job is being processed.
[4.x] Added "Attempts" to jobs lists.
# Conflicts: # CHANGELOG.md
# Conflicts: # .travis.yml # composer.json
[4.x] Update to Symfony 5
# Conflicts: # .travis.yml
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md # resources/js/screens/recentJobs/index.vue
# Conflicts: # CHANGELOG.md
# Conflicts: # resources/js/screens/recentJobs/index.vue
|
Updated this manually |
|
Thanks, I don't know what I did with this PR, I think my client glitched up. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous PR #755 I exported the
<tr>element to its own component and added the job ID in the title for debugging purposes, we do not need it in production.