[4.0] Changed default Redis prefix #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
|
A really welcomed change, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you are running multiple installations of Horizon on the same server you have to change HORIZON_PREFIX environment variable to unique value for every installation.
Sometimes I was forgetting to change HORIZON_PREFIX when I ran multiple installations of Horizon on the same server. And I found that many people have had this problem too.
So I provide more flexible default Redis prefix based on APP_NAME variable (inspired by default session prefix in Laravel).
I talked with @driesvints and he suggested that this improvement can affect existing projects. I agree with him and I think that it will be better to add this improvement in a next major release (like 4.0.0).