Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Format numbers on the stats dashboard for better readability #462

Merged
merged 1 commit into from
Jan 10, 2019
Merged

[2.0] Format numbers on the stats dashboard for better readability #462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions resources/assets/js/pages/Dashboard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
* Count processes for the given supervisor.
*/
countProcesses(processes) {
return _.chain(processes).values().sum().value()
return _.chain(processes).values().sum().value().toLocaleString()
},


Expand Down Expand Up @@ -139,21 +139,21 @@
<h2 class="stat-title">Jobs Per Minute</h2>
<h3 class="stat-meta">&nbsp;</h3>
<span class="stat-value">
{{ stats.jobsPerMinute }}
{{ stats.jobsPerMinute.toLocaleString() }}
</span>
</div>
<div class="stat col-3 p-4">
<h2 class="stat-title">Jobs past hour</h2>
<h3 class="stat-meta">&nbsp;</h3>
<span class="stat-value">
{{ stats.recentJobs }}
{{ stats.recentJobs.toLocaleString() }}
</span>
</div>
<div class="stat col-3 p-4">
<h2 class="stat-title">Failed Jobs past hour</h2>
<h3 class="stat-meta">&nbsp;</h3>
<span class="stat-value">
{{ stats.recentlyFailed }}
{{ stats.recentlyFailed.toLocaleString() }}
</span>
</div>
<div class="stat col-3 p-4 border-right-0">
Expand All @@ -172,7 +172,7 @@
<h2 class="stat-title">Total Processes</h2>
<h3 class="state-meta">&nbsp;</h3>
<span class="stat-value">
{{ stats.processes }}
{{ stats.processes.toLocaleString() }}
</span>
</div>

Expand Down Expand Up @@ -223,8 +223,8 @@
<td>
<span>{{ queue.name }}</span>
</td>
<td>{{ queue.processes }}</td>
<td>{{ queue.length }}</td>
<td>{{ queue.processes.toLocaleString() }}</td>
<td>{{ queue.length.toLocaleString() }}</td>
<td>{{ humanTime(queue.wait) }}</td>
</tr>
</tbody>
Expand Down