Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Format numbers on the stats dashboard for better readability #462

Merged
merged 1 commit into from
Jan 10, 2019
Merged

[2.0] Format numbers on the stats dashboard for better readability #462

merged 1 commit into from
Jan 10, 2019

Conversation

michaeldyrynda
Copy link
Contributor

Convert integer values on the stats dashboard using toLocaleString() to make them more easily readable.

Current
image

Proposed
image

@driesvints driesvints changed the title Format numbers on the stats dashboard for better readability [2.0] Format numbers on the stats dashboard for better readability Jan 10, 2019
@taylorotwell taylorotwell merged commit bfad893 into laravel:2.0 Jan 10, 2019
@JayBizzle
Copy link
Contributor

I see this has been merged and released in v2.0.1 but don't the assets need recompiling for the change to take effect?

/ping @driesvints

@JayBizzle
Copy link
Contributor

Looks like it has now been compiled in v2.0.2 👍

@eduPHP eduPHP mentioned this pull request Jan 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaeldyrynda @JayBizzle @driesvints @taylorotwell