Alphabetically sort jobs/queues for metrics #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for helping me giving more detailed information about PR #1078 |
|
Wow - I didn't see your PR, how funny. This was just something that's been bugging me for a while and finally had time to have a play with. Great minds think alike! |
|
@dwightwatson LOL... =) I have 0 patience to write more than needed. The most important thing... it's ordered now. =) Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change, but this will alphabetically sort the job classes and queue names before returning them to the Horizon front-end. I'm not sure what the default ordering is - possibly something internal to Redis, or the order the jobs are seen by Horizon. However, when you have a large number of jobs it can be hard to find what you're looking for. I think it makes sense to sort alphabetically so at least there is a predictable order.
For context - here's the first 4 jobs shown in my app without this ordering change and it's all over the shop.