Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort resources #1078

Closed
wants to merge 1 commit into from
Closed

Sort resources #1078

wants to merge 1 commit into from

Conversation

andreladocruz
Copy link

Apply sorting to Jobs and queue lists

Apply sorting to Jobs and queue lists
@taylorotwell
Copy link
Member

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

@andreladocruz
Copy link
Author

@taylorotwell ,

I was just sorting the list of Jobs and Queues as it's done in the workload controller.

JUST THIS!!!!!

The benefit is not having a complete MESSED list of jobs and queues.

Is kind of bizarre how bureaucracy has impregnated the development world.

A adding a simple "->sort()->values()" now requires the Pope to approve it.

This is very sad.

@andreladocruz
Copy link
Author

@taylorotwell ... just see the dam commit and you will see how complex was this change.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants