Fix cleaning up the test directory on windows CI #3297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminwinger
force-pushed
the
msvc-runner-temp-fix
branch
7 times, most recently
from
6752b62
to
778f5d7
Compare
The windows and macos CI run multiple tests in different build directories as the same user. Since #3290 this means that the tests use the same temporary directory, and the cleanup_test may remove tests from other runs. This uses the RUNNER_TEMP environment variable to create job-specific test directories on the runner machines
benjaminwinger
force-pushed
the
msvc-runner-temp-fix
branch
from
778f5d7
to
7aecec2
Compare
andyfengHKU
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows and macos CI run multiple tests in different build directories as the same user. Since #3290 this means that the tests use the same temporary directory, and the cleanup_test may remove tests from other runs. This makes the test suite use the RUNNER_TEMP environment variable for the test directory if available.