Move tests into system temporary directory #3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminwinger
force-pushed
the
test-tmpdir
branch
4 times, most recently
from
40c1d7d
to
d038898
Compare
ray6080
approved these changes
Apr 16, 2024
benjaminwinger
force-pushed
the
test-tmpdir
branch
from
d038898
to
a40fbac
Compare
benjaminwinger
added a commit
that referenced
this pull request
Apr 16, 2024
The windows CI runs multiple tests in different build directories as the same user. Since #3290 this means that the tests use the same temporary directory, and the cleanup_test may remove tests from other runs. This adds an environment variable KUZU_TEST_TMP_DIR which can be used to configure the temp directory, and uses it to create job-specific test directories on the windows runner
benjaminwinger
added a commit
that referenced
this pull request
Apr 16, 2024
The windows CI runs multiple tests in different build directories as the same user. Since #3290 this means that the tests use the same temporary directory, and the cleanup_test may remove tests from other runs. This adds an environment variable KUZU_TEST_TMP_DIR which can be used to configure the temp directory, and uses it to create job-specific test directories on the windows runner
benjaminwinger
added a commit
that referenced
this pull request
Apr 16, 2024
The windows CI runs multiple tests in different build directories as the same user. Since #3290 this means that the tests use the same temporary directory, and the cleanup_test may remove tests from other runs. This adds an environment variable KUZU_TEST_TMP_DIR which can be used to configure the temp directory, and uses it to create job-specific test directories on the windows runner
benjaminwinger
added a commit
that referenced
this pull request
Apr 16, 2024
The windows CI runs multiple tests in different build directories as the same user. Since #3290 this means that the tests use the same temporary directory, and the cleanup_test may remove tests from other runs. This adds an environment variable KUZU_TEST_TMP_DIR which can be used to configure the temp directory, and uses it to create job-specific test directories on the windows runner
benjaminwinger
added a commit
that referenced
this pull request
Apr 17, 2024
The windows and macos CI run multiple tests in different build directories as the same user. Since #3290 this means that the tests use the same temporary directory, and the cleanup_test may remove tests from other runs. This adds an environment variable KUZU_TEST_TMP_DIR which can be used to configure the temp directory, and uses it to create job-specific test directories on the runner machines
benjaminwinger
added a commit
that referenced
this pull request
Apr 17, 2024
The windows and macos CI run multiple tests in different build directories as the same user. Since #3290 this means that the tests use the same temporary directory, and the cleanup_test may remove tests from other runs. This adds an environment variable KUZU_TEST_TMP_DIR which can be used to configure the temp directory, and uses it to create job-specific test directories on the runner machines
benjaminwinger
added a commit
that referenced
this pull request
Apr 18, 2024
The windows and macos CI run multiple tests in different build directories as the same user. Since #3290 this means that the tests use the same temporary directory, and the cleanup_test may remove tests from other runs. This adds an environment variable KUZU_TEST_TMP_DIR which can be used to configure the temp directory, and uses it to create job-specific test directories on the runner machines
benjaminwinger
added a commit
that referenced
this pull request
Apr 18, 2024
The windows and macos CI run multiple tests in different build directories as the same user. Since #3290 this means that the tests use the same temporary directory, and the cleanup_test may remove tests from other runs. This uses the RUNNER_TEMP environment variable to create job-specific test directories on the runner machines
benjaminwinger
added a commit
that referenced
this pull request
Apr 18, 2024
The windows and macos CI run multiple tests in different build directories as the same user. Since #3290 this means that the tests use the same temporary directory, and the cleanup_test may remove tests from other runs. This uses the RUNNER_TEMP environment variable to create job-specific test directories on the runner machines
benjaminwinger
added a commit
that referenced
this pull request
Apr 18, 2024
The windows and macos CI run multiple tests in different build directories as the same user. Since #3290 this means that the tests use the same temporary directory, and the cleanup_test may remove tests from other runs. This uses the RUNNER_TEMP environment variable to create job-specific test directories on the runner machines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent addition of calling fsync when flushing the WAL file has slowed down tests somewhat (on my system it went from ~50s to ~66s to run the test suite). And while before using a high filesystem commit time would actually mean that nothing needs to be written to the disk when tests are running since they are removed before they are written, fsync bypasses that and it ends up writing about 3.5GB of additional data to the disk each time the test runs.
This moves the temporary test directories into
/tmp/kuzu(or equivalent on other systems, it usesstd::filesystem::temp_directory_path).