Commits on Dec 4, 2023

1. cmake: enable Wall …

   As pointed out in #2536, -Wall is not enabled. -Wextra will follow in a
   separate PR.
   
   The main changes needed are:
   - Consistent use of either struct/class for a symbol, not a mix.
   - Don't call `std::move()` on temporaries, the compiler will elide the
     copy anyway.
   - Constructor initialization order should be the same as the member
     order. It turns out that C++ will always initialize the fields in the
     member order, regardless of the initialization list ordering.
   - Mark functions in header files as inline. Inline static doesn't really
     make sense it seems, and Apple mistakenly warns about it. Inline
     functions already have no linkage.

   

   Riolku committed Dec 4, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 03607fb
   • Browse repository at this point

   Copy the full SHA

   03607fb View commit details

   Browse the repository at this point in the history