cmake: enable Wall #2541
Merged
cmake: enable Wall #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2541 +/- ##
==========================================
- Coverage 92.86% 92.85% -0.02%
==========================================
Files 1025 1025
Lines 38342 38338 -4
==========================================
- Hits 35608 35597 -11
- Misses 2734 2741 +7 ☔ View full report in Codecov by Sentry. |
Riolku
force-pushed
the
enable-more-warnings
branch
3 times, most recently
from
c01e1b9
to
e7f9853
Compare
As pointed out in #2536, -Wall is not enabled. -Wextra will follow in a separate PR. The main changes needed are: - Consistent use of either struct/class for a symbol, not a mix. - Don't call `std::move()` on temporaries, the compiler will elide the copy anyway. - Constructor initialization order should be the same as the member order. It turns out that C++ will always initialize the fields in the member order, regardless of the initialization list ordering. - Mark functions in header files as inline. Inline static doesn't really make sense it seems, and Apple mistakenly warns about it. Inline functions already have no linkage.
Riolku
force-pushed
the
enable-more-warnings
branch
from
e7f9853
to
03607fb
Compare
acquamarin
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #2536, -Wall is not enabled. -Wextra will follow in a separate PR.
The main changes needed are:
std::move()on temporaries, the compiler will elide the copy anyway.