build: enable Werror on non-Windows #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riolku
force-pushed
the
enable-werror
branch
4 times, most recently
from
25699ac
to
b5ff8bd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2335 +/- ##
=======================================
Coverage 88.61% 88.61%
=======================================
Files 1002 1002
Lines 32893 32893
=======================================
+ Hits 29147 29149 +2
+ Misses 3746 3744 -2
☔ View full report in Codecov by Sentry. |
Because of our changes recently, we can now build the project with -Werror. However, this doesn't enable all warnings. We should add warnings to the list of flagged warnings so as to forbid more and more bad code. Windows is simply too noisy to enable -Werror for right now.
ray6080
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of our changes recently, we can now build the project with -Werror. However, this doesn't enable all warnings. We should add warnings to the list of flagged warnings so as to forbid more and more bad code.
Windows is simply too noisy to enable -Werror for right now.