Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Werror #2039

Open
2 of 4 tasks
Riolku opened this issue Sep 15, 2023 · 1 comment
Open
2 of 4 tasks

Enable Werror #2039

Riolku opened this issue Sep 15, 2023 · 1 comment
Assignees
@mxwli

Comments

@Riolku
Copy link
Contributor

Riolku commented Sep 15, 2023 •
edited
Loading

#2038 has shown that segfaults can be caught as warnings in CI, but only if we turn on -Werror. Unfortunately, right now our codebase has many warnings during compilation.

Tasks:

  • Get rid of ANTLR4 warnings. (Ref Upgrade ANTLR4 runtime #2040)
  • Get rid of warnings where we have unreachable code.
  • Get rid of any remaining warnings
  • Enable -Werror for all compilers in CI.
Riolku added a commit that referenced this issue Sep 15, 2023
@Riolku
Upgrade ANTLR4 runtime
4b63a56 
Ref #2039. This fixes the warnings when we compile the runtime.
Riolku added a commit that referenced this issue Sep 15, 2023
@Riolku
Upgrade ANTLR4 runtime
c0c3df0 
Ref #2039. This fixes the warnings when we compile the runtime.
@Riolku Riolku mentioned this issue Sep 15, 2023
Merged
Riolku added a commit that referenced this issue Sep 15, 2023
@Riolku
Upgrade ANTLR4 runtime
d8a5ca4 
Ref #2039. This fixes the warnings when we compile the runtime.
@Riolku
Copy link
Contributor Author

Riolku commented Nov 13, 2023

#2335 enables -Werror on non-Windows platforms. What remains is to enable more warnings for *nix platforms, fix the warnings on windows, and enable -Werror on Windows.

@Riolku Riolku closed this as completed Nov 13, 2023
@ray6080 ray6080 reopened this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mxwli mxwli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ray6080 @Riolku @mxwli