tidy: Fix clang-tidy-17 warnings #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2284 +/- ##
==========================================
- Coverage 89.73% 89.71% -0.02%
==========================================
Files 1027 1027
Lines 36151 36079 -72
==========================================
- Hits 32440 32369 -71
+ Misses 3711 3710 -1
☔ View full report in Codecov by Sentry. |
Riolku
force-pushed
the
fix-tidy-17
branch
4 times, most recently
from
df07f24
to
8e5e218
Compare
acquamarin
approved these changes
Oct 27, 2023
| @@ -781,6 +781,9 @@ std::vector<std::string> LogicalTypeUtils::parseStructFields(const std::string& | |||
| startPos = curPos + 1; | |||
| } | |||
| } break; | |||
| default: { | |||
| // Normal character, continue. | |||
There was a problem hiding this comment.
No because it's important that curPos++ (below) is run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.