tidy: Fix clang-tidy-17 warnings

src/common/assert.cpp

@@ -2,18 +2,16 @@
 
 #include "common/exception/internal.h"
 #include "common/string_format.h"
-#include "common/utils.h"
 
 namespace kuzu {
 namespace common {
 
-void kuAssertInternal(bool condition, const char* condition_name, const char* file, int linenr) {
-    if (!condition) {
-        // LCOV_EXCL_START
-        throw InternalException(stringFormat(
-            "Assertion triggered in file \"{}\" on line {}: {}", file, linenr, condition_name));
-        // LCOV_EXCL_END
-    }
+[[noreturn]] void kuAssertFailureInternal(
+    const char* condition_name, const char* file, int linenr) {
+    // LCOV_EXCL_START
+    throw InternalException(stringFormat(
+        "Assertion failed in file \"{}\" on line {}: {}", file, linenr, condition_name));
+    // LCOV_EXCL_END
 }
 
 } // namespace common

src/common/types/types.cpp

@@ -781,6 +781,9 @@ std::vector<std::string> LogicalTypeUtils::parseStructFields(const std::string&
                 startPos = curPos + 1;
             }
         } break;
+        default: {
+            // Normal character, continue.
+        }
         }
         curPos++;
     }

src/include/common/assert.h

@@ -2,9 +2,12 @@
 
 namespace kuzu {
 namespace common {
-void kuAssertInternal(bool condition, const char* condition_name, const char* file, int linenr);
+[[noreturn]] void kuAssertFailureInternal(const char* condition_name, const char* file, int linenr);
 
 #define KU_ASSERT(condition)                                                                       \
-    kuzu::common::kuAssertInternal(bool(condition), #condition, __FILE__, __LINE__)
+    if (!(condition)) {                                                                            \
+        [[unlikely]] kuzu::common::kuAssertFailureInternal(#condition, __FILE__, __LINE__);        \
+    }
+
 } // namespace common
 } // namespace kuzu

src/include/processor/operator/persistent/delete_executor.h

@@ -9,7 +9,7 @@ namespace processor {
 
 class NodeDeleteExecutor {
 public:
-    NodeDeleteExecutor(const DataPos& nodeIDPos) : nodeIDPos{nodeIDPos} {}
+    NodeDeleteExecutor(const DataPos& nodeIDPos) : nodeIDPos{nodeIDPos}, nodeIDVector(nullptr) {}
     virtual ~NodeDeleteExecutor() = default;
 
     virtual void init(ResultSet* resultSet, ExecutionContext* context);
@@ -67,7 +67,8 @@ class RelDeleteExecutor {
 public:
     RelDeleteExecutor(
         const DataPos& srcNodeIDPos, const DataPos& dstNodeIDPos, const DataPos& relIDPos)
-        : srcNodeIDPos{srcNodeIDPos}, dstNodeIDPos{dstNodeIDPos}, relIDPos{relIDPos} {}
+        : srcNodeIDPos{srcNodeIDPos}, dstNodeIDPos{dstNodeIDPos}, relIDPos{relIDPos},
+          srcNodeIDVector(nullptr), dstNodeIDVector(nullptr), relIDVector(nullptr) {}
     virtual ~RelDeleteExecutor() = default;
 
     void init(ResultSet* resultSet, ExecutionContext* context);
@@ -86,19 +87,17 @@ class RelDeleteExecutor {
     common::ValueVector* relIDVector;
 };
 
-class SingleLabelRelDeleteExecutor : public RelDeleteExecutor {
+class SingleLabelRelDeleteExecutor final : public RelDeleteExecutor {
 public:
     SingleLabelRelDeleteExecutor(storage::RelsStoreStats* relsStatistic, storage::RelTable* table,
         const DataPos& srcNodeIDPos, const DataPos& dstNodeIDPos, const DataPos& relIDPos)
         : RelDeleteExecutor(srcNodeIDPos, dstNodeIDPos, relIDPos),
           relsStatistic{relsStatistic}, table{table} {}
-    SingleLabelRelDeleteExecutor(const SingleLabelRelDeleteExecutor& other)
-        : RelDeleteExecutor(other.srcNodeIDPos, other.dstNodeIDPos, other.relIDPos),
-          relsStatistic{other.relsStatistic}, table{other.table} {}
+    SingleLabelRelDeleteExecutor(const SingleLabelRelDeleteExecutor& other) = default;
 
-    void delete_() final;
+    void delete_();
 
-    inline std::unique_ptr<RelDeleteExecutor> copy() const final {
+    inline std::unique_ptr<RelDeleteExecutor> copy() const {
         return std::make_unique<SingleLabelRelDeleteExecutor>(*this);
     }
 
@@ -107,7 +106,7 @@ class SingleLabelRelDeleteExecutor : public RelDeleteExecutor {
     storage::RelTable* table;
 };
 
-class MultiLabelRelDeleteExecutor : public RelDeleteExecutor {
+class MultiLabelRelDeleteExecutor final : public RelDeleteExecutor {
     using rel_table_statistic_pair = std::pair<storage::RelTable*, storage::RelsStoreStats*>;
 
 public:
@@ -116,13 +115,11 @@ class MultiLabelRelDeleteExecutor : public RelDeleteExecutor {
         const DataPos& srcNodeIDPos, const DataPos& dstNodeIDPos, const DataPos& relIDPos)
         : RelDeleteExecutor(srcNodeIDPos, dstNodeIDPos, relIDPos), tableIDToTableMap{std::move(
                                                                        tableIDToTableMap)} {}
-    MultiLabelRelDeleteExecutor(const MultiLabelRelDeleteExecutor& other)
-        : RelDeleteExecutor(other.srcNodeIDPos, other.dstNodeIDPos, other.relIDPos),
-          tableIDToTableMap{other.tableIDToTableMap} {}
+    MultiLabelRelDeleteExecutor(const MultiLabelRelDeleteExecutor& other) = default;
 
-    void delete_() final;
+    void delete_();
 
-    inline std::unique_ptr<RelDeleteExecutor> copy() const final {
+    inline std::unique_ptr<RelDeleteExecutor> copy() const {
         return std::make_unique<MultiLabelRelDeleteExecutor>(*this);
     }
 

src/parser/query/CMakeLists.txt

@@ -1,9 +1,5 @@
 add_subdirectory(reading_clause)
 
-add_library(kuzu_parser_query
-        OBJECT
-        single_query.cpp)
-
 set(ALL_OBJECT_FILES
-        ${ALL_OBJECT_FILES} $<TARGET_OBJECTS:kuzu_parser_query>
+        ${ALL_OBJECT_FILES}
         PARENT_SCOPE)

src/processor/operator/persistent/reader/csv/driver.cpp

@@ -95,8 +95,9 @@ void SniffCSVNameAndTypeDriver::addValue(uint64_t, common::column_id_t, std::str
         try {
             columnType = LogicalTypeUtils::dataTypeFromString(std::string(value.substr(it + 1)));
             columnName = std::string(value.substr(0, it));
-        } catch (NotImplementedException) {
-            // Just use the whole name.
+        } catch (Exception) { // NOLINT(bugprone-empty-catch): This is how we check for a suitable
+                              // datatype name.
+            // Didn't parse, just use the whole name.
         }
     }
     columns.emplace_back(columnName, columnType);

src/processor/result/factorized_table.cpp

@@ -1,5 +1,6 @@
 #include "processor/result/factorized_table.h"
 
+#include "common/assert.h"
 #include "common/data_chunk/data_chunk_state.h"
 #include "common/null_buffer.h"
 #include "common/vector/value_vector.h"
@@ -197,6 +198,7 @@ void FactorizedTable::lookup(std::vector<ValueVector*>& vectors,
     uint64_t startPos, uint64_t numTuplesToRead) const {
     assert(vectors.size() == colIdxesToScan.size());
     auto tuplesToRead = std::make_unique<uint8_t*[]>(tupleIdxesToRead.size());
+    KU_ASSERT(numTuplesToRead > 0);
     for (auto i = 0u; i < numTuplesToRead; i++) {
         tuplesToRead[i] = getTuple(tupleIdxesToRead[i + startPos]);
     }

src/storage/buffer_manager/buffer_manager.cpp

@@ -2,12 +2,12 @@
 
 #include "common/constants.h"
 #include "common/exception/buffer_manager.h"
-#include "spdlog/spdlog.h"
 
 #if defined(_WIN32)
 #include <exception>
 
 #include <eh.h>
+#include <winnt.h>
 #endif
 
 using namespace kuzu::common;
@@ -107,6 +107,11 @@ uint8_t* BufferManager::pin(
         case PageState::LOCKED: {
             continue;
         }
+        default: {
+            // LCOV_EXCL_START
+            throw NotImplementedException("Invalid PageState in BufferManager::pin!");
+            // LCOV_EXCL_END
+        }
         }
     }
 }