Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/c_api: don't use database if unecessary #2234

Merged
merged 1 commit into from
Oct 18, 2023
Merged

test/c_api: don't use database if unecessary #2234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/storage/buffer_manager/vm_region.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ void VMRegion::releaseFrame(frame_idx_t frameIdx) {
frame_group_idx_t VMRegion::addNewFrameGroup() {
std::unique_lock xLck{mtx};
if (numFrameGroups >= maxNumFrameGroups) {
// LCOV_EXCL_START
throw BufferManagerException("No more frame groups can be added to the allocator.");
// LCOV_EXCL_END
}
return numFrameGroups++;
}
Expand Down
19 changes: 6 additions & 13 deletions test/c_api/data_type_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,7 @@
using namespace kuzu::main;
using namespace kuzu::common;

class CApiDataTypeTest : public CApiTest {
public:
std::string getInputDir() override {
return TestHelper::appendKuzuRootPath("dataset/tinysnb/");
}
};

TEST_F(CApiDataTypeTest, Create) {
TEST(CApiDataTypeTest, Create) {
auto dataType = kuzu_data_type_create(kuzu_data_type_id::KUZU_INT64, nullptr, 0);
ASSERT_NE(dataType, nullptr);
auto dataTypeCpp = (LogicalType*)dataType->_data_type;
Expand All @@ -34,7 +27,7 @@ TEST_F(CApiDataTypeTest, Create) {
kuzu_data_type_destroy(dataType3);
}

TEST_F(CApiDataTypeTest, Clone) {
TEST(CApiDataTypeTest, Clone) {
auto dataType = kuzu_data_type_create(kuzu_data_type_id::KUZU_INT64, nullptr, 0);
ASSERT_NE(dataType, nullptr);
auto dataTypeClone = kuzu_data_type_clone(dataType);
Expand Down Expand Up @@ -67,7 +60,7 @@ TEST_F(CApiDataTypeTest, Clone) {
kuzu_data_type_destroy(dataTypeClone3);
}

TEST_F(CApiDataTypeTest, Eqauls) {
TEST(CApiDataTypeTest, Eqauls) {
auto dataType = kuzu_data_type_create(kuzu_data_type_id::KUZU_INT64, nullptr, 0);
ASSERT_NE(dataType, nullptr);
auto dataTypeClone = kuzu_data_type_clone(dataType);
Expand Down Expand Up @@ -98,7 +91,7 @@ TEST_F(CApiDataTypeTest, Eqauls) {
kuzu_data_type_destroy(dataTypeClone3);
}

TEST_F(CApiDataTypeTest, GetID) {
TEST(CApiDataTypeTest, GetID) {
auto dataType = kuzu_data_type_create(kuzu_data_type_id::KUZU_INT64, nullptr, 0);
ASSERT_NE(dataType, nullptr);
ASSERT_EQ(kuzu_data_type_get_id(dataType), kuzu_data_type_id::KUZU_INT64);
Expand All @@ -118,7 +111,7 @@ TEST_F(CApiDataTypeTest, GetID) {

// TODO(Chang): The getChildType interface has been removed from the C++ DataType class.
// Consider adding the StructType/ListType helper to C binding.
// TEST_F(CApiDataTypeTest, GetChildType) {
// TEST(CApiDataTypeTest, GetChildType) {
// auto dataType = kuzu_data_type_create(kuzu_data_type_id::KUZU_INT64, nullptr, 0);
// ASSERT_NE(dataType, nullptr);
// ASSERT_EQ(kuzu_data_type_get_child_type(dataType), nullptr);
Expand All @@ -143,7 +136,7 @@ TEST_F(CApiDataTypeTest, GetID) {
// kuzu_data_type_destroy(dataType);
//}

TEST_F(CApiDataTypeTest, GetFixedNumElementsInList) {
TEST(CApiDataTypeTest, GetFixedNumElementsInList) {
auto dataType = kuzu_data_type_create(kuzu_data_type_id::KUZU_INT64, nullptr, 0);
ASSERT_NE(dataType, nullptr);
ASSERT_EQ(kuzu_data_type_get_fixed_num_elements_in_list(dataType), 0);
Expand Down
46 changes: 23 additions & 23 deletions test/c_api/value_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class CApiValueTest : public CApiTest {
}
};

TEST_F(CApiValueTest, CreateNull) {
TEST(CApiValueTestEmptyDB, CreateNull) {
kuzu_value* value = kuzu_value_create_null();
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -18,7 +18,7 @@ TEST_F(CApiValueTest, CreateNull) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateNullWithDatatype) {
TEST(CApiValueTestEmptyDB, CreateNullWithDatatype) {
auto type = kuzu_data_type_create(kuzu_data_type_id::KUZU_INT64, nullptr, 0);
kuzu_value* value = kuzu_value_create_null_with_data_type(type);
ASSERT_FALSE(value->_is_owned_by_cpp);
Expand All @@ -29,7 +29,7 @@ TEST_F(CApiValueTest, CreateNullWithDatatype) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, IsNull) {
TEST(CApiValueTestEmptyDB, IsNull) {
kuzu_value* value = kuzu_value_create_int64(123);
ASSERT_FALSE(value->_is_owned_by_cpp);
ASSERT_FALSE(kuzu_value_is_null(value));
Expand All @@ -39,7 +39,7 @@ TEST_F(CApiValueTest, IsNull) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, SetNull) {
TEST(CApiValueTestEmptyDB, SetNull) {
kuzu_value* value = kuzu_value_create_int64(123);
ASSERT_FALSE(value->_is_owned_by_cpp);
ASSERT_FALSE(kuzu_value_is_null(value));
Expand All @@ -50,7 +50,7 @@ TEST_F(CApiValueTest, SetNull) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateDefault) {
TEST(CApiValueTestEmptyDB, CreateDefault) {
auto type = kuzu_data_type_create(kuzu_data_type_id::KUZU_INT64, nullptr, 0);
kuzu_value* value = kuzu_value_create_default(type);
ASSERT_FALSE(value->_is_owned_by_cpp);
Expand All @@ -72,7 +72,7 @@ TEST_F(CApiValueTest, CreateDefault) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateBool) {
TEST(CApiValueTestEmptyDB, CreateBool) {
kuzu_value* value = kuzu_value_create_bool(true);
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -88,7 +88,7 @@ TEST_F(CApiValueTest, CreateBool) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateInt8) {
TEST(CApiValueTestEmptyDB, CreateInt8) {
kuzu_value* value = kuzu_value_create_int8(12);
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -97,7 +97,7 @@ TEST_F(CApiValueTest, CreateInt8) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateInt16) {
TEST(CApiValueTestEmptyDB, CreateInt16) {
kuzu_value* value = kuzu_value_create_int16(123);
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -106,7 +106,7 @@ TEST_F(CApiValueTest, CreateInt16) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateInt32) {
TEST(CApiValueTestEmptyDB, CreateInt32) {
kuzu_value* value = kuzu_value_create_int32(123);
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -115,7 +115,7 @@ TEST_F(CApiValueTest, CreateInt32) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateInt64) {
TEST(CApiValueTestEmptyDB, CreateInt64) {
kuzu_value* value = kuzu_value_create_int64(123);
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -124,7 +124,7 @@ TEST_F(CApiValueTest, CreateInt64) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateUInt8) {
TEST(CApiValueTestEmptyDB, CreateUInt8) {
kuzu_value* value = kuzu_value_create_uint8(12);
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -133,7 +133,7 @@ TEST_F(CApiValueTest, CreateUInt8) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateUInt16) {
TEST(CApiValueTestEmptyDB, CreateUInt16) {
kuzu_value* value = kuzu_value_create_uint16(123);
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -142,7 +142,7 @@ TEST_F(CApiValueTest, CreateUInt16) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateUInt32) {
TEST(CApiValueTestEmptyDB, CreateUInt32) {
kuzu_value* value = kuzu_value_create_uint32(123);
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -151,7 +151,7 @@ TEST_F(CApiValueTest, CreateUInt32) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateUInt64) {
TEST(CApiValueTestEmptyDB, CreateUInt64) {
kuzu_value* value = kuzu_value_create_uint64(123);
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -160,7 +160,7 @@ TEST_F(CApiValueTest, CreateUInt64) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateFloat) {
TEST(CApiValueTestEmptyDB, CreateFloat) {
kuzu_value* value = kuzu_value_create_float(123.456);
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -169,7 +169,7 @@ TEST_F(CApiValueTest, CreateFloat) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateDouble) {
TEST(CApiValueTestEmptyDB, CreateDouble) {
kuzu_value* value = kuzu_value_create_double(123.456);
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -178,7 +178,7 @@ TEST_F(CApiValueTest, CreateDouble) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateInternalID) {
TEST(CApiValueTestEmptyDB, CreateInternalID) {
auto internalID = kuzu_internal_id_t{1, 123};
kuzu_value* value = kuzu_value_create_internal_id(internalID);
ASSERT_FALSE(value->_is_owned_by_cpp);
Expand All @@ -190,7 +190,7 @@ TEST_F(CApiValueTest, CreateInternalID) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateDate) {
TEST(CApiValueTestEmptyDB, CreateDate) {
kuzu_value* value = kuzu_value_create_date(kuzu_date_t{123});
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -200,7 +200,7 @@ TEST_F(CApiValueTest, CreateDate) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateTimeStamp) {
TEST(CApiValueTestEmptyDB, CreateTimeStamp) {
kuzu_value* value = kuzu_value_create_timestamp(kuzu_timestamp_t{123});
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -210,7 +210,7 @@ TEST_F(CApiValueTest, CreateTimeStamp) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateInterval) {
TEST(CApiValueTestEmptyDB, CreateInterval) {
kuzu_value* value = kuzu_value_create_interval(kuzu_interval_t{12, 3, 300});
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -222,7 +222,7 @@ TEST_F(CApiValueTest, CreateInterval) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, CreateString) {
TEST(CApiValueTestEmptyDB, CreateString) {
kuzu_value* value = kuzu_value_create_string((char*)"abcdefg");
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -231,7 +231,7 @@ TEST_F(CApiValueTest, CreateString) {
kuzu_value_destroy(value);
}

TEST_F(CApiValueTest, Clone) {
TEST(CApiValueTestEmptyDB, Clone) {
kuzu_value* value = kuzu_value_create_string((char*)"abcdefg");
ASSERT_FALSE(value->_is_owned_by_cpp);
auto cppValue = static_cast<Value*>(value->_value);
Expand All @@ -248,7 +248,7 @@ TEST_F(CApiValueTest, Clone) {
kuzu_value_destroy(clone);
}

TEST_F(CApiValueTest, Copy) {
TEST(CApiValueTestEmptyDB, Copy) {
kuzu_value* value = kuzu_value_create_string((char*)"abc");

kuzu_value* value2 = kuzu_value_create_string((char*)"abcdefg");
Expand Down