Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/c_api: don't use database if unecessary #2234

Merged
merged 1 commit into from
Oct 18, 2023
Merged

test/c_api: don't use database if unecessary #2234

merged 1 commit into from
Oct 18, 2023

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Oct 18, 2023

A small optimization in release mode (but a large optimization in debug mode), we can avoid creating a database in our CApi tests in some cases.

A small optimization in release mode (but a large optimization in debug
mode), we can avoid creating a database in our CApi tests in some cases.
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b79718b) 89.67% compared to head (ce90d01) 89.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2234   +/-   ##
=======================================
  Coverage   89.67%   89.68%           
=======================================
  Files        1008     1008           
  Lines       35830    35830           
=======================================
+ Hits        32131    32133    +2     
+ Misses       3699     3697    -2     
Files Coverage Δ
src/storage/buffer_manager/vm_region.cpp 86.66% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Riolku Riolku merged commit 6702b5d into master Oct 18, 2023
12 checks passed
@Riolku Riolku deleted the c-api-emptydb branch October 18, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants