Pytest windows parser exception #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 5, 2023 16:34
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2157 +/- ##
==========================================
- Coverage 89.65% 89.64% -0.01%
==========================================
Files 989 989
Lines 35712 35712
==========================================
- Hits 32016 32015 -1
- Misses 3696 3697 +1 ☔ View full report in Codecov by Sentry. |
mewim
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Python test to do the same thing done in Node.js test and Java test.
This has been demonstrated to work on GitHub-provided Ubuntu 20.04, macOS, and Windows runners:
https://github.com/kuzudb/kuzu/actions/runs/6424722853
But I then reverted the commit required for the demonstration since the CI changes aren't ready to be merged into master yet.
Fixes #2010.