Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python API multiple tests fail due to Parser exception on Windows #2010

Closed
russell-liu opened this issue Sep 8, 2023 · 2 comments · Fixed by #2157
Closed

Python API multiple tests fail due to Parser exception on Windows #2010

russell-liu opened this issue Sep 8, 2023 · 2 comments · Fixed by #2157

Comments

@russell-liu
Copy link
Contributor

Example failed run on windows-2022 GitHub-hosted runner -- logs and workflow file:
https://github.com/kuzudb/kuzu/actions/runs/6122723770/job/16619119282
There does not seem to be any evidence of these tests ever passing on a Windows machine.

@mewim
Copy link
Member

mewim commented Sep 11, 2023

The failures are likely due to path handling issues on Windows. We need to modify the test suites to normalize the paths for Python on Windows platform.

@benjaminwinger
Copy link
Collaborator

The failures are likely due to path handling issues on Windows. We need to modify the test suites to normalize the paths for Python on Windows platform.

I'm not sure that it's the fault of the test suite as much as the fault of the query parser (which I'm guessing doesn't fully support windows paths right now). I think it's properly treating the backslashes as literal backslashes and not escapes, e.g. the logs show them both with escapes and without for the following query (from here), which as far as I can tell uses a valid windows path:

  • 'COPY person FROM "D:\\a\\kuzu\\kuzu\\dataset\\tinysnb/vPerson.csv" (HeaDER=true, deLim=\',\');'
  • "COPY person FROM "D:\a\kuzu\kuzu\dataset\tinysnb/vPerson.csv" (HeaDER=true, deLim=',');"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants