Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline generated export headers #2124

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Inline generated export headers #2124

merged 1 commit into from
Oct 2, 2023

Conversation

benjaminwinger
Copy link
Collaborator

#2118 broke the single file header generator script because it adds a cmake-generated header which resides in the build directory (probably should add tests to CI for the header generator at some point). This adds the build directory to the list of directories to search for header files when creating the single file header.

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (86d0c96) 89.61% compared to head (e87c39b) 89.61%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2124   +/-   ##
=======================================
  Coverage   89.61%   89.61%           
=======================================
  Files         988      988           
  Lines       35644    35645    +1     
=======================================
+ Hits        31944    31945    +1     
  Misses       3700     3700           

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger changed the title Add build directory to header search path to include generated header Inline generated export headers Oct 1, 2023
@benjaminwinger
Copy link
Collaborator Author

Re-written to just inline the headers since this also breaks the single file C header which gets included verbatim without substituting includes.

@mewim mewim merged commit 4927efe into master Oct 2, 2023
10 of 11 checks passed
@mewim mewim deleted the header-generator-fix branch October 2, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants