Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue with the windows build failing due to too many symbols.
Instead of exporting all symbols, this only exports those which are explicitly marked as part of the exported API. We probably don't want to enable this except for on Windows for the moment, since the
KUZU_API
annotations weren't previously strictly enforced and may not be complete. But I've enabled it on linux for testing to try and catch things that should be exported. (Edit: now disabled)I've included the change from #2107 to help test, as those can link against the shared library, unlike the tests. I think we probably in the long run should rewrite the API tests to link against the shared library so we can make sure all the APIs are accessible, but they currently use helper functions and classes which are private.
In addition to avoiding the error on Windows this will be helpful on all platforms eventually, as it should reduce the size of the shared library and speed up library loading.
On Linux there is a related issue where the dynamic library exports all the symbols from static libraries linked to it. It should be possible to avoid that using linker version files I think, but it's not a priority right now, and this issue doesn't appear to occur on windows.