Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Compression #2102

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Optional Compression #2102

merged 1 commit into from
Oct 2, 2023

Conversation

benjaminwinger
Copy link
Collaborator

@benjaminwinger benjaminwinger commented Sep 27, 2023

Not quite done since it's currently only exposed in the C++ and Rust APIs, and the option needs to be passed to NodeColumns.

Python and C don't currently have any sort of SystemConfig structure and only take the buffer pool size as an argument. (Edit: Added for python and C APIs)
It looks the same for nodejs and java (which I'm much less familiar with).

An optional argument would probably work fine for python, but since C lacks default values it should probably also have a SystemConfig struct that can be passed to kuzu_database_init. (done)

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f1f7b75) 89.63% compared to head (5164b3e) 89.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2102      +/-   ##
==========================================
+ Coverage   89.63%   89.66%   +0.03%     
==========================================
  Files         988      988              
  Lines       35717    35729      +12     
==========================================
+ Hits        32014    32036      +22     
+ Misses       3703     3693      -10     
Files Coverage Δ
src/c_api/database.cpp 85.00% <100.00%> (+1.66%) ⬆️
.../include/processor/operator/persistent/copy_node.h 100.00% <100.00%> (ø)
src/include/storage/local_storage.h 100.00% <ø> (ø)
src/include/storage/local_table.h 100.00% <100.00%> (ø)
src/include/storage/storage_manager.h 100.00% <100.00%> (ø)
src/include/storage/store/column_chunk.h 90.74% <100.00%> (+0.17%) ⬆️
src/include/storage/store/node_column.h 100.00% <ø> (ø)
src/include/storage/store/node_group.h 100.00% <ø> (ø)
src/include/storage/store/node_table.h 100.00% <ø> (ø)
src/include/storage/store/nodes_store.h 100.00% <100.00%> (ø)
... and 22 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger force-pushed the compression-option branch 2 times, most recently from 4ed6bc7 to 8516c2c Compare September 28, 2023 21:23
@benjaminwinger benjaminwinger marked this pull request as ready for review September 28, 2023 21:24
@ray6080 ray6080 self-requested a review September 29, 2023 04:09
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a plan to test the configuration inside cpp?

src/include/c_api/kuzu.h Outdated Show resolved Hide resolved
src/include/storage/local_storage.h Outdated Show resolved Hide resolved
@benjaminwinger
Copy link
Collaborator Author

Is there a plan to test the configuration inside cpp?

Not really. We could maybe expose information about the properties which could include the compression information for each column chunk. That could be useful later for examining the efficiency of the compression (e.g. if it also reports the compressed size and the number of values stored).

@benjaminwinger benjaminwinger force-pushed the compression-option branch 2 times, most recently from 12ace7e to c9b4cae Compare September 29, 2023 21:59
@ray6080
Copy link
Contributor

ray6080 commented Sep 30, 2023

We should also add an arg nocompression to CLI.

@benjaminwinger benjaminwinger force-pushed the compression-option branch 3 times, most recently from 209de0e to fda2301 Compare October 1, 2023 00:53
@ray6080 ray6080 merged commit 7308523 into master Oct 2, 2023
10 of 11 checks passed
@ray6080 ray6080 deleted the compression-option branch October 2, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants