-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional Compression #2102
Optional Compression #2102
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2102 +/- ##
==========================================
+ Coverage 89.63% 89.66% +0.03%
==========================================
Files 988 988
Lines 35717 35729 +12
==========================================
+ Hits 32014 32036 +22
+ Misses 3703 3693 -10
☔ View full report in Codecov by Sentry. |
4ed6bc7
to
8516c2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a plan to test the configuration inside cpp?
Not really. We could maybe expose information about the properties which could include the compression information for each column chunk. That could be useful later for examining the efficiency of the compression (e.g. if it also reports the compressed size and the number of values stored). |
12ace7e
to
c9b4cae
Compare
We should also add an arg |
209de0e
to
fda2301
Compare
c292c22
to
b96204e
Compare
b96204e
to
5164b3e
Compare
Not quite done since it's currently only exposed in the C++ and Rust APIs, and the option needs to be passed to NodeColumns.Python and C don't currently have any sort of SystemConfig structure and only take the buffer pool size as an argument. (Edit: Added for python and C APIs)
It looks the same for nodejs and java (which I'm much less familiar with).
An optional argument would probably work fine for python, but since C lacks default values it should probably also have a SystemConfig struct that can be passed to
kuzu_database_init
. (done)