Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression Setting #2048

Closed
benjaminwinger opened this issue Sep 18, 2023 · 1 comment
Closed

Compression Setting #2048

benjaminwinger opened this issue Sep 18, 2023 · 1 comment

Comments

@benjaminwinger
Copy link
Collaborator

From #2004 (review).

For #2004 it would be helpful to have a runtime database option (e.g. ENABLE_COMPRESSION) for enabling/disabling compression.

I'm not entirely sure how we would want to implement such a thing, as it presumably should be a persistent setting, not just a setting for accessing the database like bufferPoolsize and maxNumThreads in the SystemConfig struct. That being said, since #2004 stores compression information per-chunk, it certainly would be possible to change the setting after the database has been created, it would just mean that the new setting would only affect new ColumnChunks (unless there is some re-processing done to update the existing data to match the new value of the setting).

@benjaminwinger
Copy link
Collaborator Author

Fixed by #2102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant