Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bounds check in integer bitpacking #2091

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

benjaminwinger
Copy link
Collaborator

Fixes #2087

The incorrect logic in this comparison was causing an overflow in the output buffer when decompressing (though the values up to the overflow would still be correct).

Most of the tests use far fewer values than the default capacity (node group size), so this isn't well covered by our test suite. I'm not positive why the ASAN CI is passing, except that it may be related to differences between gcc (used by CI) and clang (used in #2087).

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d5fe4d3) 88.92% compared to head (08a353f) 88.91%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2091      +/-   ##
==========================================
- Coverage   88.92%   88.91%   -0.02%     
==========================================
  Files         987      987              
  Lines       36060    36060              
==========================================
- Hits        32067    32063       -4     
- Misses       3993     3997       +4     
Files Coverage Δ
src/binder/bind/bind_copy.cpp 91.66% <100.00%> (ø)
.../processor/operator/persistent/reader/npy_reader.h 100.00% <ø> (ø)
src/include/storage/store/column_chunk.h 88.46% <100.00%> (ø)
...ssor/operator/persistent/reader/npy/npy_reader.cpp 77.88% <100.00%> (ø)
...processor/operator/persistent/reader_functions.cpp 86.66% <100.00%> (ø)
src/processor/operator/persistent/reader_state.cpp 100.00% <ø> (ø)
src/storage/store/column_chunk.cpp 55.83% <100.00%> (ø)
src/storage/store/compression.cpp 77.05% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger merged commit 3753f71 into master Sep 26, 2023
11 checks passed
@benjaminwinger benjaminwinger deleted the decompression-overflow-fix branch September 26, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compression Test fail ASAN
2 participants