Fix bounds check in integer bitpacking #2091
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2087
The incorrect logic in this comparison was causing an overflow in the output buffer when decompressing (though the values up to the overflow would still be correct).
Most of the tests use far fewer values than the default capacity (node group size), so this isn't well covered by our test suite. I'm not positive why the ASAN CI is passing, except that it may be related to differences between gcc (used by CI) and clang (used in #2087).