Merge pull request #2091 from kuzudb/decompression-overflow-fix

Fix bounds check in integer bitpacking
kuzudb · Sep 26, 2023 · 3753f71 · 3753f71
2 parents 9b4fd80 + 08a353f
commit 3753f71
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/storage/store/compression.cpp b/src/storage/store/compression.cpp
@@ -296,7 +296,7 @@ void IntegerBitpacking<T>::decompressFromPage(const uint8_t* srcBuffer, uint64_t
     }
 
     // Use fastunpack to directly unpack the full-sized chunks
-    for (; dstIndex < dstOffset + numValues - numValues % CHUNK_SIZE; dstIndex += CHUNK_SIZE) {
+    for (; dstIndex + CHUNK_SIZE <= dstOffset + numValues; dstIndex += CHUNK_SIZE) {
         FastPForLib::fastunpack(
             (const uint32_t*)srcCursor, (U*)dstBuffer + dstIndex, header.bitWidth);
         if (header.hasNegative) {