Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitpack VAR_LIST offset data #2084

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Bitpack VAR_LIST offset data #2084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/storage/store/column_chunk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ ColumnChunk::ColumnChunk(
GetCompressionMetadata(std::make_unique<IntegerBitpacking<int32_t>>(), this->dataType);
break;
}
case PhysicalTypeID::VAR_LIST:
case PhysicalTypeID::UINT64: {
flushBufferFunction =
CompressedFlushBuffer(std::make_unique<IntegerBitpacking<uint64_t>>(), this->dataType);
Expand Down
5 changes: 5 additions & 0 deletions src/storage/store/compression.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@
return IntegerBitpacking<int32_t>::canUpdateInPlace(
value, BitpackHeader::readHeader(data));
}
case PhysicalTypeID::VAR_LIST:
case PhysicalTypeID::UINT64: {
auto value = vector.getValue<uint64_t>(pos);
return IntegerBitpacking<uint64_t>::canUpdateInPlace(
Expand Down Expand Up @@ -120,6 +121,7 @@
return IntegerBitpacking<int64_t>::numValues(pageSize, BitpackHeader::readHeader(data));
case PhysicalTypeID::INT32:
return IntegerBitpacking<int32_t>::numValues(pageSize, BitpackHeader::readHeader(data));
case PhysicalTypeID::VAR_LIST:
case PhysicalTypeID::UINT64:
return IntegerBitpacking<int64_t>::numValues(pageSize, BitpackHeader::readHeader(data));
case PhysicalTypeID::UINT32:
Expand Down Expand Up @@ -382,6 +384,7 @@
return IntegerBitpacking<int32_t>().decompressFromPage(frame, pageCursor.elemPosInPage,
resultVector->getData(), posInVector, numValuesToRead, metadata);
}
case PhysicalTypeID::VAR_LIST:
case PhysicalTypeID::UINT64: {
return IntegerBitpacking<uint64_t>().decompressFromPage(frame, pageCursor.elemPosInPage,
resultVector->getData(), posInVector, numValuesToRead, metadata);
Expand Down Expand Up @@ -419,6 +422,7 @@
return IntegerBitpacking<int32_t>().decompressFromPage(frame, pageCursor.elemPosInPage,
result, startPosInResult, numValuesToRead, metadata);
}
case PhysicalTypeID::VAR_LIST:
case PhysicalTypeID::UINT64: {
return IntegerBitpacking<uint64_t>().decompressFromPage(frame, pageCursor.elemPosInPage,
result, startPosInResult, numValuesToRead, metadata);
Expand Down Expand Up @@ -455,6 +459,7 @@
return IntegerBitpacking<int32_t>().setValueFromUncompressed(
vector->getData(), posInVector, frame, posInFrame, metadata);
}
case PhysicalTypeID::VAR_LIST:

Check warning on line 462 in src/storage/store/compression.cpp

View check run for this annotation

Codecov / codecov/patch

src/storage/store/compression.cpp#L462 

Added line #L462 was not covered by tests
case PhysicalTypeID::UINT64: {
return IntegerBitpacking<uint64_t>().setValueFromUncompressed(
vector->getData(), posInVector, frame, posInFrame, metadata);
Expand Down