Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitpack VAR_LIST offset data #2084

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

benjaminwinger
Copy link
Collaborator

Functionally identical to UINT64, (for the offsets at least), which makes this very simple

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (da22d9e) 90.21% compared to head (8f382a9) 90.24%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2084      +/-   ##
==========================================
+ Coverage   90.21%   90.24%   +0.02%     
==========================================
  Files         966      970       +4     
  Lines       35019    35077      +58     
==========================================
+ Hits        31593    31655      +62     
+ Misses       3426     3422       -4     
Files Coverage Δ
src/storage/store/column_chunk.cpp 77.97% <100.00%> (ø)
src/storage/store/compression.cpp 78.35% <75.00%> (+1.29%) ⬆️

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger merged commit 9b4fd80 into master Sep 26, 2023
11 checks passed
@benjaminwinger benjaminwinger deleted the var-list-offset-compression branch September 26, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants