Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arrow feature to rust example so that it can re-use the test build in CI #2002

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

benjaminwinger
Copy link
Collaborator

Following up #1995, this should let the rust example use the previously built version of the kuzu crate in CI, as they'll now use the same features.

I'm tempted to also actually include an example of using the arrow data in the example, but it makes the example a lot more complex and I'm not sure if it really helps provide a good example of kuzu's interfaces as most of it would be dealing with arrow types.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (ad5fa79) 90.29% compared to head (9dedddc) 90.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2002      +/-   ##
==========================================
- Coverage   90.29%   90.28%   -0.01%     
==========================================
  Files         883      883              
  Lines       32411    32411              
==========================================
- Hits        29264    29261       -3     
- Misses       3147     3150       +3     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@benjaminwinger
Copy link
Collaborator Author

It does appear to be working correctly. The paths in the logs match, and the rust example compilation time went down from ~4 minutes to 52 seconds.

@benjaminwinger benjaminwinger merged commit e030f73 into master Sep 11, 2023
10 checks passed
@benjaminwinger benjaminwinger deleted the rust-example-arrow branch September 11, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants