Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share build cache when building rust API and the example project #1995

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

russell-liu
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (520d496) 90.29% compared to head (b0f5959) 90.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1995   +/-   ##
=======================================
  Coverage   90.29%   90.29%           
=======================================
  Files         883      883           
  Lines       32411    32411           
=======================================
+ Hits        29265    29267    +2     
+ Misses       3146     3144    -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benjaminwinger benjaminwinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the logs, it looks like it's still using separate build directories. I think that's because the example doesn't use the arrow feature, so it then separately builds kuzu without the arrow feature to use with the example.

What we could do is have the example build require the arrow feature (or give it a feature that depends on the kuzu crate's arrow feature). So why don't we merge this for now, and I'll add an arrow feature to the example in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants