Set CMAKE_BUILD_PARALLEL_LEVEL so that NUM_THREADS gets passed to the arrow build in CI #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… arrow build in CI This should also be more portable in the rust build than NUM_JOBS
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1764 +/- ##
==========================================
- Coverage 91.17% 91.17% -0.01%
==========================================
Files 769 769
Lines 28177 28177
==========================================
- Hits 25690 25689 -1
- Misses 2487 2488 +1 ☔ View full report in Codecov by Sentry. |
mewim
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that moving the arrow build in #1752 into the configure step means that it no longer respects the number of threads set in CI. However, the number of threads used can also be configured via the
CMAKE_BUILD_PARALLEL_LEVELenvironment variable, so I've set up the makefile to set that based on the value ofNUM_THREADS.