Unified CMake Build

[benjaminwinger]

Addresses an issue mentioned in #1736 and also #1745 by running the apache arrow cmake build during the configure step of the kuzu cmake build.

This might be a little unexpected since you don't usually expect a large and slow compilation step when running the configure step, but USE_SYSTEM_ARROW and ARROW_INSTALL can still be used to avoid building arrow by pointing it at a pre-built version.

I simplified the makefile accordingly, but didn't entirely remove it. There are some situations where it is still helpful to provide default settings, particularly in the case of Windows MSVC builds where (last I checked) the default Visual Studio generator produces build errors. The makefile targets are also being used for CI, though they could be inlined into the CI files.

Note that while this removes the distinction between make clean and make clean-all, you can still clean without removing arrow by running make clean inside the build directory, i.e. on the cmake generated makefile, when using the makefile generator (not quite the same as removing all the files, but it's close enough for most purposes I think).

I also took the liberty of setting GIT_SHALLOW on the arrow ExternalProject (cuts the download size from >100MB to ~20MB), and since it requires a named tag, also updated that to 12.0.1, which seems to work fine.

[ray6080]

LGTM

[LowLevelMahn]

There are some situations where it is still helpful to provide default settings

isn't that also possible with CMake only - defaults but overwriteable?

something like:

https://cmake.org/cmake/help/latest/command/set.html

set(BUILD_PARAMETERXYZ false CACHE BOOL "Use to activate XYZ feature")

It is possible for the cache entry to exist prior to the call but have no type set if it was created on the cmake(1) command line by a user through the -D= option without specifying a type. In this case the set command will add the type. Furthermore, if the is PATH or FILEPATH and the provided on the command line is a relative path, then the set command will treat the path as relative to the current working directory and convert it to an absolute path.

so this way BUILD_PARAMETERXYZ is set to false per default but can be overwritten by -D parameter or CMake-UI

[benjaminwinger]

isn't that also possible with CMake only - defaults but overwriteable?

Not for the generator as far as I can tell, but presumably everything else should be.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (7ff1fe5) 91.15% compared to head (d7e541d) 91.16%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1752      +/-   ##
==========================================
+ Coverage   91.15%   91.16%   +0.01%     
==========================================
  Files         769      769              
  Lines       28089    28089              
==========================================
+ Hits        25604    25608       +4     
+ Misses       2485     2481       -4     

see 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.