Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor explain pipeline #1747

Merged
merged 1 commit into from
Jun 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/binder/bind/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ add_library(
bind_standalone_call.cpp
bind_copy.cpp
bind_ddl.cpp
bind_explain.cpp
bind_graph_pattern.cpp
bind_projection_clause.cpp
bind_query.cpp
Expand Down
15 changes: 15 additions & 0 deletions src/binder/bind/bind_explain.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#include "binder/binder.h"
#include "binder/bound_explain.h"
#include "parser/explain_statement.h"

namespace kuzu {
namespace binder {

std::unique_ptr<BoundStatement> Binder::bindExplain(const parser::Statement& statement) {
auto& explainStatement = (parser::ExplainStatement&)statement;
auto boundStatementToExplain = bind(*explainStatement.getStatementToExplain());
return std::make_unique<BoundExplain>(std::move(boundStatementToExplain));
}

} // namespace binder
} // namespace kuzu
5 changes: 4 additions & 1 deletion src/binder/binder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,12 @@ std::unique_ptr<BoundStatement> Binder::bind(const Statement& statement) {
case StatementType::QUERY: {
return bindQuery((const RegularQuery&)statement);
}
case StatementType::StandaloneCall: {
case StatementType::STANDALONE_CALL: {
return bindStandaloneCall(statement);
}
case StatementType::EXPLAIN: {
return bindExplain(statement);
}
default:
assert(false);
}
Expand Down
11 changes: 10 additions & 1 deletion src/binder/bound_statement_visitor.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#include "binder/bound_statement_visitor.h"

#include "binder/bound_explain.h"

using namespace kuzu::common;

namespace kuzu {
Expand Down Expand Up @@ -34,9 +36,12 @@ void BoundStatementVisitor::visit(const kuzu::binder::BoundStatement& statement)
case StatementType::COPY: {
visitCopy(statement);
} break;
case StatementType::StandaloneCall: {
case StatementType::STANDALONE_CALL: {
visitStandaloneCall(statement);
} break;
case StatementType::EXPLAIN: {
visitExplain(statement);
} break;
default:
throw NotImplementedException("BoundStatementVisitor::visit");
}
Expand Down Expand Up @@ -69,6 +74,10 @@ void BoundStatementVisitor::visitQueryPart(const NormalizedQueryPart& queryPart)
}
}

void BoundStatementVisitor::visitExplain(const BoundStatement& statement) {
visit(*((const BoundExplain&)statement).getStatementToExplain());
}

void BoundStatementVisitor::visitReadingClause(const BoundReadingClause& readingClause) {
switch (readingClause.getClauseType()) {
case common::ClauseType::MATCH: {
Expand Down
3 changes: 3 additions & 0 deletions src/include/binder/binder.h
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ class Binder {
/*** bind call ***/
std::unique_ptr<BoundStatement> bindStandaloneCall(const parser::Statement& statement);

/*** bind explain ***/
std::unique_ptr<BoundStatement> bindExplain(const parser::Statement& statement);

/*** bind reading clause ***/
std::unique_ptr<BoundReadingClause> bindReadingClause(
const parser::ReadingClause& readingClause);
Expand Down
22 changes: 22 additions & 0 deletions src/include/binder/bound_explain.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
#pragma once

#include "binder/bound_statement.h"

namespace kuzu {
namespace binder {

class BoundExplain : public BoundStatement {
public:
explicit BoundExplain(std::unique_ptr<BoundStatement> statementToExplain)
: BoundStatement{common::StatementType::EXPLAIN,
BoundStatementResult::createSingleStringColumnResult()},
statementToExplain{std::move(statementToExplain)} {}

inline BoundStatement* getStatementToExplain() const { return statementToExplain.get(); }

private:
std::unique_ptr<BoundStatement> statementToExplain;
};

} // namespace binder
} // namespace kuzu
1 change: 1 addition & 0 deletions src/include/binder/bound_statement_visitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ class BoundStatementVisitor {
virtual void visitRenameProperty(const BoundStatement& statement) {}
virtual void visitCopy(const BoundStatement& statement) {}
virtual void visitStandaloneCall(const BoundStatement& statement) {}
virtual void visitExplain(const BoundStatement& statement);

void visitReadingClause(const BoundReadingClause& readingClause);
virtual void visitMatch(const BoundReadingClause& readingClause) {}
Expand Down
2 changes: 1 addition & 1 deletion src/include/binder/call/bound_standalone_call.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace binder {
class BoundStandaloneCall : public BoundStatement {
public:
BoundStandaloneCall(main::ConfigurationOption option, std::shared_ptr<Expression> optionValue)
: BoundStatement{common::StatementType::StandaloneCall,
: BoundStatement{common::StatementType::STANDALONE_CALL,
BoundStatementResult::createEmptyResult()},
option{option}, optionValue{optionValue} {}

Expand Down
3 changes: 2 additions & 1 deletion src/include/common/statement_type.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ enum class StatementType : uint8_t {
DROP_PROPERTY = 7,
RENAME_PROPERTY = 8,
COPY = 20,
StandaloneCall = 21,
STANDALONE_CALL = 21,
EXPLAIN = 22,
};

class StatementTypeUtils {
Expand Down
9 changes: 8 additions & 1 deletion src/include/main/query_summary.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ namespace main {
*/
struct PreparedSummary {
double compilingTime = 0;
// Only used for printing by shell.
bool isExplain = false;
bool isProfile = false;
};
Expand All @@ -33,7 +34,6 @@ class QuerySummary {
* @return query execution time in milliseconds.
*/
KUZU_API double getExecutionTime() const;
bool getIsExplain() const;
bool getIsProfile() const;
std::ostringstream& getPlanAsOstream();
/**
Expand All @@ -42,12 +42,19 @@ class QuerySummary {
KUZU_API std::string getPlan();
void setPreparedSummary(PreparedSummary preparedSummary_);

/**
* @return true if the query is executed with EXPLAIN.
*/
inline bool isExplain() const { return preparedSummary.isExplain; }

private:
nlohmann::json& printPlanToJson();

private:
double executionTime = 0;
PreparedSummary preparedSummary;
// Remove these two field once we have refactored the profiler using the existing pipeline
// design.
std::unique_ptr<nlohmann::json> planInJson;
std::ostringstream planInOstream;
};
Expand Down
2 changes: 1 addition & 1 deletion src/include/parser/call/standalone_call.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace parser {
class StandaloneCall : public Statement {
public:
explicit StandaloneCall(std::string optionName, std::unique_ptr<ParsedExpression> optionValue)
: Statement{common::StatementType::StandaloneCall}, optionName{std::move(optionName)},
: Statement{common::StatementType::STANDALONE_CALL}, optionName{std::move(optionName)},
optionValue{std::move(optionValue)} {}

inline std::string getOptionName() const { return optionName; }
Expand Down
21 changes: 21 additions & 0 deletions src/include/parser/explain_statement.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
#pragma once

#include "parser/statement.h"

namespace kuzu {
namespace parser {

class ExplainStatement : public Statement {
public:
explicit ExplainStatement(std::unique_ptr<Statement> statementToExplain)
: Statement{common::StatementType::EXPLAIN}, statementToExplain{
std::move(statementToExplain)} {}

inline Statement* getStatementToExplain() const { return statementToExplain.get(); }

private:
std::unique_ptr<Statement> statementToExplain;
};

} // namespace parser
} // namespace kuzu
5 changes: 0 additions & 5 deletions src/include/parser/statement.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,11 @@ class Statement {

inline common::StatementType getStatementType() const { return statementType; }

inline void enableExplain() { explain = true; }
inline bool isExplain() const { return explain; }

inline void enableProfile() { profile = true; }
inline bool isProfile() const { return profile; }

private:
common::StatementType statementType;
// If explain is enabled, we do not execute query but return physical plan only.
bool explain = false;
bool profile = false;
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ enum class LogicalOperatorType : uint8_t {
DROP_PROPERTY,
DROP_TABLE,
EXPRESSIONS_SCAN,
EXPLAIN,
EXTEND,
FILTER,
FLATTEN,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
#pragma once

#include "base_logical_operator.h"

namespace kuzu {
namespace planner {

class LogicalExplain : public LogicalOperator {
public:
LogicalExplain(std::shared_ptr<LogicalOperator> child,
std::shared_ptr<binder::Expression> outputExpression)
: LogicalOperator{LogicalOperatorType::EXPLAIN, child}, outputExpression{
std::move(outputExpression)} {}

void computeFactorizedSchema() override;
void computeFlatSchema() override;

inline std::shared_ptr<binder::Expression> getOutputExpression() const {
return outputExpression;
}

inline std::string getExpressionsForPrinting() const override { return "Explain"; }

inline std::unique_ptr<LogicalOperator> copy() override {
return std::make_unique<LogicalExplain>(children[0], outputExpression);
}

protected:
std::shared_ptr<binder::Expression> outputExpression;
};

} // namespace planner
} // namespace kuzu
4 changes: 4 additions & 0 deletions src/include/planner/planner.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ class Planner {
const catalog::Catalog& catalog, const BoundStatement& statement);

static std::unique_ptr<LogicalPlan> planStandaloneCall(const BoundStatement& statement);

static std::unique_ptr<LogicalPlan> planExplain(const catalog::Catalog& catalog,
const storage::NodesStatisticsAndDeletedIDs& nodesStatistics,
const storage::RelsStatistics& relsStatistics, const BoundStatement& statement);
};

} // namespace planner
Expand Down
2 changes: 2 additions & 0 deletions src/include/processor/mapper/plan_mapper.h
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ class PlanMapper {
planner::LogicalOperator* logicalOperator);
std::unique_ptr<PhysicalOperator> mapLogicalInQueryCallToPhysical(
planner::LogicalOperator* logicalOperator);
std::unique_ptr<PhysicalOperator> mapLogicalExplainToPhysical(
planner::LogicalOperator* logicalOperator);
std::unique_ptr<ResultCollector> appendResultCollector(
const binder::expression_vector& expressionsToCollect, planner::Schema* schema,
std::unique_ptr<PhysicalOperator> prevOperator);
Expand Down
41 changes: 19 additions & 22 deletions src/main/connection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,9 @@ std::unique_ptr<PreparedStatement> Connection::prepareNoLock(
try {
// parsing
auto statement = Parser::parseQuery(query);
preparedStatement->preparedSummary.isExplain = statement->isExplain();
preparedStatement->preparedSummary.isProfile = statement->isProfile();
preparedStatement->preparedSummary.isExplain =
acquamarin marked this conversation as resolved.
Show resolved Hide resolved
statement->getStatementType() == StatementType::EXPLAIN;
// binding
auto binder = Binder(*database->catalog);
auto boundStatement = binder.bind(*statement);
Expand Down Expand Up @@ -354,27 +355,23 @@ std::unique_ptr<QueryResult> Connection::executeAndAutoCommitIfNecessaryNoLock(
auto executionContext =
std::make_unique<ExecutionContext>(clientContext->numThreadsForExecution, profiler.get(),
database->memoryManager.get(), database->bufferManager.get(), clientContext.get());
// Execute query if EXPLAIN is not enabled.
if (!preparedStatement->preparedSummary.isExplain) {
profiler->enabled = preparedStatement->preparedSummary.isProfile;
auto executingTimer = TimeMetric(true /* enable */);
executingTimer.start();
std::shared_ptr<FactorizedTable> resultFT;
try {
beginTransactionIfAutoCommit(preparedStatement);
executionContext->transaction = activeTransaction.get();
resultFT =
database->queryProcessor->execute(physicalPlan.get(), executionContext.get());
if (ConnectionTransactionMode::AUTO_COMMIT == transactionMode) {
commitNoLock();
}
} catch (Exception& exception) { return getQueryResultWithError(exception.what()); }
executingTimer.stop();
queryResult->querySummary->executionTime = executingTimer.getElapsedTimeMS();
queryResult->initResultTableAndIterator(std::move(resultFT),
preparedStatement->statementResult->getColumns(),
preparedStatement->statementResult->getExpressionsToCollectPerColumn());
}
profiler->enabled = preparedStatement->preparedSummary.isProfile;
auto executingTimer = TimeMetric(true /* enable */);
executingTimer.start();
std::shared_ptr<FactorizedTable> resultFT;
try {
beginTransactionIfAutoCommit(preparedStatement);
executionContext->transaction = activeTransaction.get();
resultFT = database->queryProcessor->execute(physicalPlan.get(), executionContext.get());
if (ConnectionTransactionMode::AUTO_COMMIT == transactionMode) {
commitNoLock();
}
} catch (Exception& exception) { return getQueryResultWithError(exception.what()); }
executingTimer.stop();
queryResult->querySummary->executionTime = executingTimer.getElapsedTimeMS();
queryResult->initResultTableAndIterator(std::move(resultFT),
preparedStatement->statementResult->getColumns(),
preparedStatement->statementResult->getExpressionsToCollectPerColumn());
auto planPrinter = std::make_unique<PlanPrinter>(physicalPlan.get(), std::move(profiler));
queryResult->querySummary->planInJson =
std::make_unique<nlohmann::json>(planPrinter->printPlanToJson());
Expand Down
3 changes: 1 addition & 2 deletions src/main/query_result.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ std::vector<common::LogicalType> QueryResult::getColumnDataTypes() const {
}

uint64_t QueryResult::getNumTuples() const {
return querySummary->getIsExplain() ? 0 : factorizedTable->getTotalNumFlatTuples();
return factorizedTable->getTotalNumFlatTuples();
}

QuerySummary* QueryResult::getQuerySummary() const {
Expand Down Expand Up @@ -185,7 +185,6 @@ void QueryResult::initResultTableAndIterator(

bool QueryResult::hasNext() const {
validateQuerySucceed();
assert(querySummary->getIsExplain() == false);
return iterator->hasNextFlatTuple();
}

Expand Down
4 changes: 0 additions & 4 deletions src/main/query_summary.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ double QuerySummary::getExecutionTime() const {
return executionTime;
}

bool QuerySummary::getIsExplain() const {
return preparedSummary.isExplain;
}

bool QuerySummary::getIsProfile() const {
return preparedSummary.isProfile;
}
Expand Down
3 changes: 2 additions & 1 deletion src/parser/transformer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include "parser/ddl/drop_table.h"
#include "parser/ddl/rename_property.h"
#include "parser/ddl/rename_table.h"
#include "parser/explain_statement.h"
#include "parser/expression/parsed_case_expression.h"
#include "parser/expression/parsed_function_expression.h"
#include "parser/expression/parsed_literal_expression.h"
Expand All @@ -32,7 +33,7 @@ std::unique_ptr<Statement> Transformer::transform() {
if (root.oC_AnyCypherOption()) {
auto cypherOption = root.oC_AnyCypherOption();
if (cypherOption->oC_Explain()) {
statement->enableExplain();
return std::make_unique<ExplainStatement>(std::move(statement));
}
if (cypherOption->oC_Profile()) {
statement->enableProfile();
Expand Down
1 change: 1 addition & 0 deletions src/planner/operator/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ add_library(kuzu_planner_operator
logical_cross_product.cpp
logical_ddl.cpp
logical_distinct.cpp
logical_explain.cpp
logical_expressions_scan.cpp
logical_extend.cpp
logical_filter.cpp
Expand Down
3 changes: 3 additions & 0 deletions src/planner/operator/base_logical_operator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ std::string LogicalOperatorUtils::logicalOperatorTypeToString(LogicalOperatorTyp
case LogicalOperatorType::EXTEND: {
return "EXTEND";
}
case LogicalOperatorType::EXPLAIN: {
return "EXPLAIN";
}
case LogicalOperatorType::FILTER: {
return "FILTER";
}
Expand Down
Loading
Loading