Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor explain pipeline #1747

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Refactor explain pipeline #1747

merged 1 commit into from
Jun 30, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Jun 30, 2023

Refactors explain to use the existing pipeline

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 98.70% and no project coverage change.

Comparison is base (e704660) 91.39% compared to head (c90ad45) 91.40%.

❗ Current head c90ad45 differs from pull request most recent head 5e2c8e3. Consider uploading reports for the commit 5e2c8e3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1747   +/-   ##
=======================================
  Coverage   91.39%   91.40%           
=======================================
  Files         760      766    +6     
  Lines       27431    27481   +50     
=======================================
+ Hits        25071    25118   +47     
- Misses       2360     2363    +3     
Impacted Files Coverage Δ
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/common/statement_type.h 100.00% <ø> (ø)
src/include/parser/statement.h 60.00% <ø> (-11.43%) ⬇️
...ical_plan/logical_operator/base_logical_operator.h 100.00% <ø> (ø)
src/include/processor/mapper/plan_mapper.h 100.00% <ø> (ø)
src/main/query_summary.cpp 46.66% <ø> (-6.28%) ⬇️
src/planner/operator/base_logical_operator.cpp 71.01% <0.00%> (-1.05%) ⬇️
src/binder/bind/bind_explain.cpp 100.00% <100.00%> (ø)
src/binder/binder.cpp 96.39% <100.00%> (+0.06%) ⬆️
src/binder/bound_statement_visitor.cpp 92.85% <100.00%> (+0.26%) ⬆️
... and 13 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/include/binder/bound_statement_visitor.h Outdated Show resolved Hide resolved
src/main/connection.cpp Show resolved Hide resolved
@acquamarin acquamarin merged commit bd0f58d into master Jun 30, 2023
7 checks passed
@acquamarin acquamarin deleted the explain-pipeline branch June 30, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants