Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append FTableScan before RecursiveJoin #1658

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

andyfengHKU
Copy link
Contributor

This PR adds a FTableScan before RecursiveJoin. Previously the same logic is written in RecrusiveJoin.

This Pr also solves issue #1347

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 98.09% and project coverage change: -0.01 ⚠️

Comparison is base (976d035) 91.45% compared to head (526176f) 91.44%.

❗ Current head 526176f differs from pull request most recent head 0ffde6f. Consider uploading reports for the commit 0ffde6f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1658      +/-   ##
==========================================
- Coverage   91.45%   91.44%   -0.01%     
==========================================
  Files         726      727       +1     
  Lines       26411    26388      -23     
==========================================
- Hits        24153    24131      -22     
+ Misses       2258     2257       -1     
Impacted Files Coverage Δ
src/processor/mapper/map_extend.cpp 96.96% <ø> (+0.85%) ⬆️
.../processor/operator/table_scan/base_table_scan.cpp 100.00% <ø> (ø)
src/processor/mapper/map_recursive_extend.cpp 94.87% <94.87%> (ø)
src/include/processor/operator/cross_product.h 100.00% <100.00%> (ø)
...ocessor/operator/recursive_extend/recursive_join.h 100.00% <100.00%> (ø)
src/include/processor/operator/result_collector.h 100.00% <100.00%> (ø)
...de/processor/operator/table_scan/base_table_scan.h 100.00% <100.00%> (ø)
...cessor/operator/table_scan/factorized_table_scan.h 78.57% <100.00%> (-1.43%) ⬇️
...ude/processor/operator/table_scan/union_all_scan.h 100.00% <100.00%> (ø)
src/include/processor/result/factorized_table.h 96.82% <100.00%> (+0.05%) ⬆️
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit 43c7026 into master Jun 9, 2023
8 checks passed
@andyfengHKU andyfengHKU deleted the ftable-scan-rework branch June 9, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants