Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify getMorsel function of FTableSharedState #1347

Closed
anuchak opened this issue Mar 6, 2023 · 1 comment
Closed

Simplify getMorsel function of FTableSharedState #1347

anuchak opened this issue Mar 6, 2023 · 1 comment

Comments

@anuchak
Copy link
Collaborator

anuchak commented Mar 6, 2023

Currently the getMorsel() function in the FTableSharedState is defined as:

std::unique_ptr getMorsel(uint64_t maxMorselSize);

This can be simplified as the maxMorselSize doesn't need to be passed everytime.
It gets set inside this struct and the function can be called directly.
@andyfengHKU andyfengHKU mentioned this issue Jun 9, 2023
Merged
@andyfengHKU
Copy link
Contributor

Solved in #1658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anuchak @andyfengHKU